From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336B0CA9ED9 for ; Tue, 5 Nov 2019 07:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07A4721929 for ; Tue, 5 Nov 2019 07:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572938357; bh=x73MAqn7pxmNqQ0SXRznXAhaMnN/ONu9VTZaW2d10ns=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=vJI21PFoeSoYftn/QksadX68FT/p1XkN1+aghHWkUmK0lkZZA7ukTFyXJrGwl5O6u Vi5Xo45uRD59474ZMYnCLTIxWqgG8RUkXPH1l7Yu5SBpiMQhu7zi5ECzXsmiZqcA6p O+lhIzJ3CrzZE+tzlluVp6KWkv5v5rnSMfH2T1m8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387766AbfKEHTP (ORCPT ); Tue, 5 Nov 2019 02:19:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:38226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387567AbfKEHTP (ORCPT ); Tue, 5 Nov 2019 02:19:15 -0500 Received: from paulmck-ThinkPad-P72.home (28.234-255-62.static.virginmediabusiness.co.uk [62.255.234.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C830E222C1; Tue, 5 Nov 2019 07:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572938354; bh=x73MAqn7pxmNqQ0SXRznXAhaMnN/ONu9VTZaW2d10ns=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=hIyl5iSgUitQdOVnnOtPdS1YTLk4zVRZcWjeK1pn153lEo3QRwGcFnNzLal8zz9AK I/832ZkUIjJbyvXDvouXCb40eUreg3YLCleSZZriZzsHXJQsNqaPClSPYbZCGIy8hF UovlnZq9RcnliiJPgYydMLx8kF9NmVqjMd9JOC4g= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id C390D35227FC; Mon, 4 Nov 2019 23:19:11 -0800 (PST) Date: Mon, 4 Nov 2019 23:19:11 -0800 From: "Paul E. McKenney" To: Lai Jiangshan Cc: Boqun Feng , linux-kernel@vger.kernel.org, Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu@vger.kernel.org Subject: Re: [PATCH V2 2/7] rcu: cleanup rcu_preempt_deferred_qs() Message-ID: <20191105071911.GL20975@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20191102124559.1135-1-laijs@linux.alibaba.com> <20191102124559.1135-3-laijs@linux.alibaba.com> <20191103020150.GA23770@tardis> <7489f817-adaf-275b-b19d-18ad248b071f@linux.alibaba.com> <20191104145539.GY20975@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 05, 2019 at 10:09:15AM +0800, Lai Jiangshan wrote: > On 2019/11/4 10:55 下午, Paul E. McKenney wrote: > > On Sun, Nov 03, 2019 at 01:01:21PM +0800, Lai Jiangshan wrote: > > > > > > > > > On 2019/11/3 10:01 上午, Boqun Feng wrote: > > > > Hi Jiangshan, > > > > > > > > > > > > I haven't checked the correctness of this patch carefully, but.. > > > > > > > > > > > > On Sat, Nov 02, 2019 at 12:45:54PM +0000, Lai Jiangshan wrote: > > > > > Don't need to set ->rcu_read_lock_nesting negative, irq-protected > > > > > rcu_preempt_deferred_qs_irqrestore() doesn't expect > > > > > ->rcu_read_lock_nesting to be negative to work, it even > > > > > doesn't access to ->rcu_read_lock_nesting any more. > > > > > > > > rcu_preempt_deferred_qs_irqrestore() will report RCU qs, and may > > > > eventually call swake_up() or its friends to wake up, say, the gp > > > > kthread, and the wake up functions could go into the scheduler code > > > > path which might have RCU read-side critical section in it, IOW, > > > > accessing ->rcu_read_lock_nesting. > > > > > > Sure, thank you for pointing it out. > > > > > > I should rewrite the changelog in next round. Like this: > > > > > > rcu: cleanup rcu_preempt_deferred_qs() > > > > > > IRQ-protected rcu_preempt_deferred_qs_irqrestore() itself doesn't > > > expect ->rcu_read_lock_nesting to be negative to work. > > > > > > There might be RCU read-side critical section in it (from wakeup() > > > or so), 1711d15bf5ef(rcu: Clear ->rcu_read_unlock_special only once) > > > will ensure that ->rcu_read_unlock_special is zero and these RCU > > > read-side critical sections will not call rcu_read_unlock_special(). > > > > > > Thanks > > > Lai > > > > > > === > > > PS: Were 1711d15bf5ef(rcu: Clear ->rcu_read_unlock_special only once) > > > not applied earlier, it will be protected by previous patch (patch1) > > > in this series > > > "rcu: use preempt_count to test whether scheduler locks is held" > > > when rcu_read_unlock_special() is called. > > > > This one in -rcu, you mean? > > > > 5c5d9065e4eb ("rcu: Clear ->rcu_read_unlock_special only once") > > Yes, but the commit ID is floating in the tree. Indeed, that part of -rcu is subject to rebase, and will continue to be until about v5.5-rc5 or thereabouts. https://mirrors.edge.kernel.org/pub/linux/kernel/people/paulmck/rcutodo.html My testing of your full stack should be complete by this coming Sunday morning, Pacific Time. > > Some adjustment was needed due to my not applying the earlier patches > > that assumed nested interrupts. Please let me know if further adjustments > > are needed. > > I don't think the earlier patches are needed. If the possible? nested > interrupts described in my previous emails is an issue, the patch > "rcu: don't use negative ->rcu_read_lock_nesting" in this > series is enough to fixed it. If any adjustments needed for > this series, I will just put the adjustments the series. Fair enough. Please to clearly mark any adjustments so that I can merge them into current commits as appropriate. This help bisectability later on. Thanx, Paul > Thanks > Lai > > > > > Thanx, Paul > > > > > > Again, haven't checked closely, but this argument in the commit log > > > > seems untrue. > > > > > > > > Regards, > > > > Boqun > > > > > > > > > > > > > > It is true that NMI over rcu_preempt_deferred_qs_irqrestore() > > > > > may access to ->rcu_read_lock_nesting, but it is still safe > > > > > since rcu_read_unlock_special() can protect itself from NMI. > > > > > > > > > > Signed-off-by: Lai Jiangshan > > > > > --- > > > > > kernel/rcu/tree_plugin.h | 5 ----- > > > > > 1 file changed, 5 deletions(-) > > > > > > > > > > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h > > > > > index aba5896d67e3..2fab8be2061f 100644 > > > > > --- a/kernel/rcu/tree_plugin.h > > > > > +++ b/kernel/rcu/tree_plugin.h > > > > > @@ -552,16 +552,11 @@ static bool rcu_preempt_need_deferred_qs(struct task_struct *t) > > > > > static void rcu_preempt_deferred_qs(struct task_struct *t) > > > > > { > > > > > unsigned long flags; > > > > > - bool couldrecurse = t->rcu_read_lock_nesting >= 0; > > > > > if (!rcu_preempt_need_deferred_qs(t)) > > > > > return; > > > > > - if (couldrecurse) > > > > > - t->rcu_read_lock_nesting -= RCU_NEST_BIAS; > > > > > local_irq_save(flags); > > > > > rcu_preempt_deferred_qs_irqrestore(t, flags); > > > > > - if (couldrecurse) > > > > > - t->rcu_read_lock_nesting += RCU_NEST_BIAS; > > > > > } > > > > > /* > > > > > -- > > > > > 2.20.1 > > > > >