From: Abel Vesa <abel.vesa@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "sboyd@kernel.org" <sboyd@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>
Subject: Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization
Date: Tue, 5 Nov 2019 11:37:58 +0000 [thread overview]
Message-ID: <20191105113757.7emblygbcqfa6gyl@fsr-ub1664-175> (raw)
In-Reply-To: <1572862200-29923-2-git-send-email-peng.fan@nxp.com>
On 19-11-04 10:11:37, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> There is no need to initialize flags as 0.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> drivers/clk/imx/clk-divider-gate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
> index 214e18eb2b22..4145594af53b 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struct clk_hw *hw,
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> unsigned int val;
>
> spin_lock_irqsave(div->lock, flags);
> @@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw, unsigned long rate,
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> int value;
> u32 val;
>
> @@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> u32 val;
>
> if (!div_gate->cached_val) {
> @@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> u32 val;
>
> spin_lock_irqsave(div->lock, flags);
> --
> 2.16.4
>
next prev parent reply other threads:[~2019-11-05 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 10:11 [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Peng Fan
2019-11-04 10:11 ` [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization Peng Fan
2019-11-05 11:37 ` Abel Vesa [this message]
2019-12-02 9:02 ` Shawn Guo
2019-12-02 9:00 ` [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105113757.7emblygbcqfa6gyl@fsr-ub1664-175 \
--to=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).