From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A6DC17460 for ; Tue, 5 Nov 2019 13:47:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C417A21928 for ; Tue, 5 Nov 2019 13:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WzMofGxa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389254AbfKENrq (ORCPT ); Tue, 5 Nov 2019 08:47:46 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38873 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388860AbfKENrq (ORCPT ); Tue, 5 Nov 2019 08:47:46 -0500 Received: by mail-wm1-f68.google.com with SMTP id z19so16030120wmk.3 for ; Tue, 05 Nov 2019 05:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nZ0NtyKlN0mECHG4PVEtPii79ddIWJ/dNETUstyjSo4=; b=WzMofGxaV4+waE9HFVg1hUeiDUkLmUiD8evWbx47N6a73UjVCKy5N69mB9gYIIbETC yn6ZaRoNcnv/5nRk5ZWIwzrIHfjBOOyK4ILGbAlAU0yTaBdDkM7UrZpZ9oIAcdnWlidk 1RFYtnbxSXEpF/Nv15GC0/Sm9nCQCGI3IQaVxkmXnS7lofKPTn8Ob08efu0TyN1iGrfY jbP0qjEfX8LUQH463Ox5r1OUv9aByO155IFwD7KIMCxkQe02cnZxZQQwFe7PqoVRzENi bVHgEBL59zCUcGveUFQUxd2dKviPjJqW9n4E4QuogiA3f/5RkOmA03w/D2zsvEFpXM6f f4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nZ0NtyKlN0mECHG4PVEtPii79ddIWJ/dNETUstyjSo4=; b=GFo2K5Vg+Yzpg7QAmUzTLg2FD08fmkcRQrABloGx0zA59eEZRyMDdg9LpSsSsB6jCf NAq64JMK1JAB1QWYJGwFNqtEzHXN/QGEULoODBWeOciuVViaPZz3PMKYO/vAt/v04j96 hZ19fVyRbTbhoT446hKjaon2LdA20nMPWRDMMVl0OBgnYeQYOxnnrsTKb3oimhMTA9yj 7JuP56/cvDzyTz+ZLUf1eSaCfEHtv/6xwNi69h+Dz2Pe5GIltecDMUiGlUEX+LYzQs80 CAP5gLKnZNRNnZqJSxXSsjL+8p1jcJ3PzdhcXmc4Migaca4Vt/o78lPunWc5LCnHQfA0 lvJQ== X-Gm-Message-State: APjAAAXhQbd7OajAcUuy0CxwvgaqiXT1xGBspiNlhlfy95TWFOycvdMw IT0gkT2l0ieolQKJ+hBGy7UZnw== X-Google-Smtp-Source: APXvYqz6TwrUtKtwRhKyTrjAPt8ruFrngSCuQfZKpEY7AkKWkRgK1SLBJ7dRQ+2weGZP3OT233hU2A== X-Received: by 2002:a1c:b404:: with SMTP id d4mr4598549wmf.9.1572961663785; Tue, 05 Nov 2019 05:47:43 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id q25sm25737207wra.3.2019.11.05.05.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 05:47:42 -0800 (PST) Date: Tue, 5 Nov 2019 13:47:42 +0000 From: Matthias Maennich To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Jessica Yu , Matthias Kaehlcke , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mospost: remove unneeded local variable in contains_namespace() Message-ID: <20191105134742.GC65671@google.com> References: <20191029123809.29301-1-yamada.masahiro@socionext.com> <20191029123809.29301-5-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191029123809.29301-5-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Tue, Oct 29, 2019 at 09:38:09PM +0900, Masahiro Yamada wrote: >The local variable, ns_entry, is unneeded. > >While I was here, I also cleaned up the comparison with NULL or 0. > >Signed-off-by: Masahiro Yamada >--- This was not directly sent to me, hence I missed it. Nevertheless, please feel free to add Reviewed-by: Matthias Maennich Cheers, Matthias > > scripts/mod/modpost.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c >index f7425f5d4ab0..f70b924f379f 100644 >--- a/scripts/mod/modpost.c >+++ b/scripts/mod/modpost.c >@@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name) > static bool contains_namespace(struct namespace_list *list, > const char *namespace) > { >- struct namespace_list *ns_entry; >- >- for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next) >- if (strcmp(ns_entry->namespace, namespace) == 0) >+ for (; list; list = list->next) >+ if (!strcmp(list->namespace, namespace)) > return true; > > return false; >-- >2.17.1 >