From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5106C5DF60 for ; Tue, 5 Nov 2019 16:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7564521882 for ; Tue, 5 Nov 2019 16:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572971018; bh=qKMYHXwfTMRpupJkytoWqg1G0C3PgmBaeYMHVkA8Ttw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Pevc8zwkJHmIaoOI3cRHbvFv5DchL5YrUZ6khDGmAaJt2eK+YGXe2Ss8+vfIWfweq 2MHnzHRe8Wf2agR3jlq0eCame4AmRdDvpRvoQMOZ1nLXTS062R/1mLPoJ+Jg+7nHtz Zj5Im0JjCNX2PkJbYfi7yI9C1R/IUE+giu1PS6s0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390171AbfKEQXP (ORCPT ); Tue, 5 Nov 2019 11:23:15 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:57266 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390082AbfKEQXN (ORCPT ); Tue, 5 Nov 2019 11:23:13 -0500 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-GCM-SHA256:128) (Exim 4.80) (envelope-from ) id 1iS1bq-0001q9-Lq; Tue, 05 Nov 2019 17:23:10 +0100 From: Marc Zyngier To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Jason Cooper , lorenzo.pieralisi@arm.com, Andrew.Murray@arm.com, yuzenghui@huawei.com, Heyi Guo Subject: [PATCH 01/11] irqchip/gic-v3-its: Free collection mapping on device teardown Date: Tue, 5 Nov 2019 16:22:48 +0000 Message-Id: <20191105162258.22214-2-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191105162258.22214-1-maz@kernel.org> References: <20191105162258.22214-1-maz@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net, lorenzo.pieralisi@arm.com, Andrew.Murray@arm.com, yuzenghui@huawei.com, guoheyi@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Somehow, we forgot to free the collection mapping when tearing down a device, hence slowly leaking mapping arrays as devices get removed from the system. That is, almost never. Just to be safe, properly free the array on device teardown. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 787e8eec9a7f..07d0bde60e16 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2471,6 +2471,7 @@ static void its_free_device(struct its_device *its_dev) raw_spin_lock_irqsave(&its_dev->its->lock, flags); list_del(&its_dev->entry); raw_spin_unlock_irqrestore(&its_dev->its->lock, flags); + kfree(its_dev->event_map.col_map); kfree(its_dev->itt); kfree(its_dev); } -- 2.20.1