From: Rob Herring <robh@kernel.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"'Uwe Kleine-König'" <u.kleine-koenig@pengutronix.de>,
"Mark Rutland" <mark.rutland@arm.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Philipp Zabel" <pza@pengutronix.de>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@siol.net>
Subject: Re: [PATCH v3 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description
Date: Tue, 5 Nov 2019 15:33:19 -0600 [thread overview]
Message-ID: <20191105213319.GA30538@bogus> (raw)
In-Reply-To: <20191105131456.32400-2-peron.clem@gmail.com>
On Tue, Nov 05, 2019 at 02:14:50PM +0100, Clément Péron wrote:
> From: Jernej Skrabec <jernej.skrabec@siol.net>
>
> H6 PWM block is basically the same as A20 PWM, except that it also has
> bus clock and reset line which needs to be handled accordingly.
>
> Expand Allwinner PWM binding with H6 PWM specifics.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> index 0ac52f83a58c..9fc32c1d94b4 100644
> --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> @@ -30,13 +30,50 @@ properties:
> - items:
> - const: allwinner,sun50i-h5-pwm
> - const: allwinner,sun5i-a13-pwm
> + - const: allwinner,sun50i-h6-pwm
>
> reg:
> maxItems: 1
>
> clocks:
> + minItems: 1
> + maxItems: 2
> + items:
> + - description: Bus Clock
> + - description: Module Clock
The order here doesn't match the if/then or the example.
> +
> + # Even though it only applies to subschemas under the conditionals,
> + # not listing them here will trigger a warning because of the
> + # additionalsProperties set to false.
> + clock-names: true
blank line here.
> + resets:
> maxItems: 1
>
> + if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun50i-h6-pwm
> +
> + then:
> + properties:
> + clocks:
> + minItems: 2
> +
> + clock-names:
> + items:
> + - const: mod
> + - const: bus
> +
> + required:
> + - clock-names
> + - resets
> +
> + else:
> + properties:
> + clocks:
> + maxItems: 1
> +
> required:
> - "#pwm-cells"
> - compatible
> @@ -54,4 +91,14 @@ examples:
> #pwm-cells = <3>;
> };
>
> + - |
> + pwm@300a000 {
> + compatible = "allwinner,sun50i-h6-pwm";
> + reg = <0x0300a000 0x400>;
> + clocks = <&osc24M>, <&ccu CLK_BUS_PWM>;
> + clock-names = "mod", "bus";
> + resets = <&ccu RST_BUS_PWM>;
> + #pwm-cells = <3>;
> + };
> +
> ...
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-11-05 21:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 13:14 [PATCH v3 0/7] Add support for H6 PWM Clément Péron
2019-11-05 13:14 ` [PATCH v3 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description Clément Péron
2019-11-05 21:33 ` Rob Herring [this message]
2019-11-05 13:14 ` [PATCH v3 2/7] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-05 13:36 ` Philipp Zabel
2019-11-05 14:01 ` Clément Péron
2019-11-05 13:53 ` Uwe Kleine-König
2019-11-05 13:14 ` [PATCH v3 3/7] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-05 13:57 ` Uwe Kleine-König
2019-11-05 14:06 ` Clément Péron
2019-11-05 13:14 ` [PATCH v3 4/7] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-05 14:56 ` Uwe Kleine-König
2019-11-06 21:24 ` Clément Péron
2019-11-07 6:51 ` Uwe Kleine-König
2019-11-08 8:34 ` Clément Péron
2019-11-05 13:14 ` [PATCH v3 5/7] pwm: sun4i: Add support for H6 PWM Clément Péron
2019-11-05 14:57 ` Uwe Kleine-König
2019-11-05 13:14 ` [PATCH v3 6/7] arm64: dts: allwinner: h6: Add PWM node Clément Péron
2019-11-05 13:14 ` [PATCH v3 7/7] [DO NOT MERGE] arm64: allwinner: h6: enable Beelink GS1 PWM Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105213319.GA30538@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=pza@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).