From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A998C5DF64 for ; Wed, 6 Nov 2019 08:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4342221929 for ; Wed, 6 Nov 2019 08:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731546AbfKFI4U (ORCPT ); Wed, 6 Nov 2019 03:56:20 -0500 Received: from retiisi.org.uk ([95.216.213.190]:55938 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfKFI4U (ORCPT ); Wed, 6 Nov 2019 03:56:20 -0500 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 0D78C634C87; Wed, 6 Nov 2019 10:55:03 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1iSH5i-0002VM-1T; Wed, 06 Nov 2019 10:55:02 +0200 Date: Wed, 6 Nov 2019 10:55:02 +0200 From: Sakari Ailus To: Benoit Parrot Cc: Hans Verkuil , linux-media@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jyri Sarha Subject: Re: [Patch v2 07/20] media: ti-vpe: cal: add CSI2 PHY LDO errata support Message-ID: <20191106085501.GA6253@valkosipuli.retiisi.org.uk> References: <20191104193140.31145-1-bparrot@ti.com> <20191104193140.31145-8-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191104193140.31145-8-bparrot@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benoit, On Mon, Nov 04, 2019 at 01:31:27PM -0600, Benoit Parrot wrote: ... > @@ -458,6 +483,8 @@ > #define CAL_CSI2_PHY_REG1_CLOCK_MISS_DETECTOR_STATUS_SUCCESS 0 > #define CAL_CSI2_PHY_REG1_RESET_DONE_STATUS_MASK GENMASK(29, 28) > > +#define CAL_CSI2_PHY_REG10_I933_LDO_DISABLE_MASK BIT_MASK(6) BIT(6) ? BIT_MASK() is intended for a different purpose. -- Regards, Sakari Ailus