From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Florian Weimer <fweimer@redhat.com>,
Shawn Landden <shawn@git.icu>,
libc-alpha@sourceware.org, linux-api@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Keith Packard <keithp@keithp.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: handle_exit_race && PF_EXITING
Date: Wed, 6 Nov 2019 11:35:10 +0100 [thread overview]
Message-ID: <20191106103509.GB12575@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1911061028020.1869@nanos.tec.linutronix.de>
On 11/06, Thomas Gleixner wrote:
>
> > @@ -716,11 +716,13 @@ void exit_pi_state_list(struct task_struct *curr)
> >
> > if (!futex_cmpxchg_enabled)
> > return;
> > +
> > /*
> > - * We are a ZOMBIE and nobody can enqueue itself on
> > - * pi_state_list anymore, but we have to be careful
> > - * versus waiters unqueueing themselves:
> > + * attach_to_pi_owner() can no longer add the new entry. But
> > + * we have to be careful versus waiters unqueueing themselves.
> > */
> > + curr->flags |= PF_EXITPIDONE;
>
> This obviously would need a barrier or would have to be moved inside of the
> pi_lock region.
probably yes,
> > + if (unlikely(p->flags & PF_EXITPIDONE)) {
> > + /* exit_pi_state_list() was already called */
> > raw_spin_unlock_irq(&p->pi_lock);
> > put_task_struct(p);
> > - return ret;
> > + return -ESRCH;
>
> But, this is incorrect because we'd return -ESRCH to user space while the
> futex value still has the TID of the exiting task set which will
> subsequently cleanout the futex and set the owner died bit.
Heh. Of course this is not correct. As I said, this patch should be adapted
to the current code. See below.
> See da791a667536 ("futex: Cure exit race") for example.
Thomas, I simply can't resist ;)
I reported this race when I sent this patch in 2015,
https://lore.kernel.org/lkml/20150205181014.GA20244@redhat.com/
but somehow that discussion died with no result.
> Guess why that code has more corner case handling than actual
> functionality. :)
I know why. To confuse me!
Oleg.
next prev parent reply other threads:[~2019-11-06 10:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 0:29 [RFC v2 PATCH] futex: extend set_robust_list to allow 2 locking ABIs at the same time Shawn Landden
2019-11-04 0:51 ` Shawn Landden
2019-11-04 15:37 ` Thomas Gleixner
2019-11-05 0:10 ` Thomas Gleixner
2019-11-05 9:48 ` Florian Weimer
2019-11-05 9:59 ` Thomas Gleixner
2019-11-05 10:06 ` Florian Weimer
2019-11-05 11:56 ` Thomas Gleixner
2019-11-05 14:10 ` Carlos O'Donell
2019-11-05 14:27 ` Florian Weimer
2019-11-05 14:53 ` Thomas Gleixner
2019-11-05 14:27 ` Thomas Gleixner
2019-11-05 14:33 ` Florian Weimer
2019-11-05 14:48 ` Thomas Gleixner
2019-11-06 14:00 ` Zack Weinberg
2019-11-06 14:04 ` Florian Weimer
2019-11-05 15:27 ` handle_exit_race && PF_EXITING Oleg Nesterov
2019-11-05 17:28 ` Thomas Gleixner
2019-11-05 17:59 ` Thomas Gleixner
2019-11-05 18:56 ` Thomas Gleixner
2019-11-05 19:19 ` Thomas Gleixner
2019-11-06 8:55 ` Oleg Nesterov
2019-11-06 9:53 ` Thomas Gleixner
2019-11-06 10:35 ` Oleg Nesterov [this message]
2019-11-06 11:07 ` Thomas Gleixner
2019-11-06 12:11 ` Oleg Nesterov
2019-11-06 13:38 ` Thomas Gleixner
2019-11-06 17:42 ` Thomas Gleixner
2019-11-07 15:51 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106103509.GB12575@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=deepa.kernel@gmail.com \
--cc=fweimer@redhat.com \
--cc=keithp@keithp.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shawn@git.icu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).