From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v4 6/9] perf stat: Factor out open error handling
Date: Wed, 6 Nov 2019 17:33:57 +0100 [thread overview]
Message-ID: <20191106163357.GM30214@krava> (raw)
In-Reply-To: <20191105002522.83803-7-andi@firstfloor.org>
On Mon, Nov 04, 2019 at 04:25:19PM -0800, Andi Kleen wrote:
SNIP
> goto try_again;
> }
>
> - /*
> - * PPC returns ENXIO for HW counters until 2.6.37
> - * (behavior changed with commit b0a873e).
> - */
> - if (errno == EINVAL || errno == ENOSYS ||
> - errno == ENOENT || errno == EOPNOTSUPP ||
> - errno == ENXIO) {
> - if (verbose > 0)
> - ui__warning("%s event is not supported by the kernel.\n",
> - perf_evsel__name(counter));
> - counter->supported = false;
> -
> - if ((counter->leader != counter) ||
> - !(counter->leader->core.nr_members > 1))
> - continue;
> - } else if (perf_evsel__fallback(counter, errno, msg, sizeof(msg))) {
> - if (verbose > 0)
> - ui__warning("%s\n", msg);
> - goto try_again;
> - } else if (target__has_per_thread(&target) &&
> - evsel_list->core.threads &&
> - evsel_list->core.threads->err_thread != -1) {
> - /*
> - * For global --per-thread case, skip current
> - * error thread.
> - */
> - if (!thread_map__remove(evsel_list->core.threads,
> - evsel_list->core.threads->err_thread)) {
> - evsel_list->core.threads->err_thread = -1;
> - goto try_again;
> - }
> + switch (stat_handle_error(counter)) {
> + case COUNTER_FATAL:
> + return -1;
> + case COUNTER_RETRY:
> + goto try_again;
> + case COUNTER_SKIP:
> + continue;
> + default:
> + break;
> }
great, looks good, thanks
jirka
> -
> - perf_evsel__open_strerror(counter, &target,
> - errno, msg, sizeof(msg));
> - ui__error("%s\n", msg);
> -
> - if (child_pid != -1)
> - kill(child_pid, SIGTERM);
> -
> - return -1;
> }
> counter->supported = true;
>
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-11-06 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:25 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-05 0:25 ` [PATCH v4 1/9] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-05 0:25 ` [PATCH v4 2/9] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-05 0:25 ` [PATCH v4 3/9] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-06 16:34 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 4/9] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-05 0:25 ` [PATCH v4 5/9] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-06 16:33 ` Jiri Olsa
2019-11-06 16:34 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 6/9] perf stat: Factor out open error handling Andi Kleen
2019-11-06 16:33 ` Jiri Olsa [this message]
2019-11-05 0:25 ` [PATCH v4 7/9] perf stat: Use affinity for opening events Andi Kleen
2019-11-06 16:34 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 8/9] perf stat: Use affinity for reading Andi Kleen
2019-11-05 0:25 ` [PATCH v4 9/9] perf stat: Use affinity for enabling/disabling events Andi Kleen
2019-11-06 16:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106163357.GM30214@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).