From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH v2] perf tests: Fix out of bounds memory access
Date: Thu, 7 Nov 2019 09:06:43 -0300 [thread overview]
Message-ID: <20191107120643.GA11372@kernel.org> (raw)
In-Reply-To: <20191107102029.GA32679@leoy-ThinkPad-X240s>
Em Thu, Nov 07, 2019 at 06:20:29PM +0800, Leo Yan escreveu:
> On Thu, Nov 07, 2019 at 10:42:26AM +0100, Jiri Olsa wrote:
> [...]
> > > To fix this issue, we will use evlist__open() and evlist__close() pair
> > > functions to prepare and cleanup context for evlist; so 'evsel->id' and
> > > 'evsel->ids' can be initialized properly when invoke do_test() and avoid
> > > the out of bounds memory access.
> > right, we need to solve this on libperf level, so it's possible
> > to call mmap/munmap multiple time without close/open.. I'll try
> > to send something, but meanwhile this is good workaround
> >
> > Reviewed-by: Jiri Olsa <jolsa@kernel.org>
> Thanks for reviewing, Jiri.
> You are welcome to send us the fixing patches, I am glad to test it on
> qemu_arm.
Thanks, applied after adding:
Fixes: ee74701ed8ad ("perf tests: Add test to check backward ring buffer")
Cc: stable@vger.kernel.org # v4.10+
Please consider doing it next time,
- Arnaldo
next prev parent reply other threads:[~2019-11-07 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 2:02 [PATCH v2] perf tests: Fix out of bounds memory access Leo Yan
2019-11-07 9:42 ` Jiri Olsa
2019-11-07 10:20 ` Leo Yan
2019-11-07 12:06 ` Arnaldo Carvalho de Melo [this message]
2019-11-07 13:35 ` Leo Yan
2019-11-12 11:17 ` [tip: perf/core] " tip-bot2 for Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107120643.GA11372@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).