From: Petr Mladek <pmladek@suse.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Joe Perches <joe@perches.com>,
"open list:TENSILICA XTENSA PORT (xtensa)"
<linux-xtensa@linux-xtensa.org>, Chris Zankel <chris@zankel.net>,
LKML <linux-kernel@vger.kernel.org>,
Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH] xtensa: improve stack dumping
Date: Thu, 7 Nov 2019 15:38:10 +0100 [thread overview]
Message-ID: <20191107143810.oon6bj7dc7xqcyxe@pathway.suse.cz> (raw)
In-Reply-To: <CAMo8BfLmcCOAinyjB3iEuOF36TYBig=724=s9b6EKr3LzwF5QQ@mail.gmail.com>
On Wed 2019-11-06 16:21:51, Max Filippov wrote:
> On Wed, Nov 6, 2019 at 2:34 PM Joe Perches <joe@perches.com> wrote:
> > > @@ -512,10 +510,12 @@ void show_stack(struct task_struct *task, unsigned long *sp)
> > > for (i = 0; i < kstack_depth_to_print; i++) {
> > > if (kstack_end(sp))
> > > break;
> > > - pr_cont(" %08lx", *sp++);
> > > + sprintf(buf + (i % 8) * 9, " %08lx", *sp++);
> > > if (i % 8 == 7)
> > > - pr_cont("\n");
> > > + pr_info("%s\n", buf);
> > > }
> > > + if (i % 8)
> > > + pr_info("%s\n", buf);
> >
> > Could this be done using hex_dump_to_buffer
> > by precalculating kstack_end ?
>
> I've got this, but it doesn't look very attractive to me:
>
> void show_stack(struct task_struct *task, unsigned long *sp)
> {
> unsigned long *stack;
> int len;
>
> if (!sp)
> sp = stack_pointer(task);
> stack = sp;
>
> len = min((-(unsigned long)stack) & (THREAD_SIZE - 4),
> kstack_depth_to_print * 4ul);
>
> pr_info("Stack:\n");
>
> for (; len > 0; len -= 32) {
> char buf[9 * 8 + 1];
>
> hex_dump_to_buffer(sp, min(len, 32), 32, 4,
> buf, sizeof(buf), false);
> pr_info(" %08lx: %s\n", (unsigned long)sp, buf);
> sp += 8;
> }
I wonder if the cycle actually could get replaced by a single call:
print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET,
16, 1, sp, len, false);
print_hex_dump() currently does not allow to print 8 bytes per-line.
Either 16 is acceptable or hex_dump() function could be updated.
Best Regards,
Petr
next prev parent reply other threads:[~2019-11-07 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:16 [PATCH] xtensa: improve stack dumping Max Filippov
2019-11-06 20:50 ` Dmitry Safonov
2019-11-06 22:00 ` Max Filippov
2019-11-06 22:18 ` Dmitry Safonov
2019-11-06 22:33 ` Joe Perches
2019-11-07 0:21 ` Max Filippov
2019-11-07 14:38 ` Petr Mladek [this message]
2019-11-07 14:45 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107143810.oon6bj7dc7xqcyxe@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=chris@zankel.net \
--cc=dima@arista.com \
--cc=jcmvbkbc@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).