From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D039C5DF60 for ; Thu, 7 Nov 2019 13:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13DC7218AE for ; Thu, 7 Nov 2019 13:52:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aepfle.de header.i=@aepfle.de header.b="NXjTJHsv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389214AbfKGNwD (ORCPT ); Thu, 7 Nov 2019 08:52:03 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.164]:9000 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389192AbfKGNwD (ORCPT ); Thu, 7 Nov 2019 08:52:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573134721; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=xePb0EruLlu0nO5HtILqFKWXJ1QLBtzbkUwOSAhevVY=; b=NXjTJHsvHtbkJP3pxp/2rSK3PLCYBdnd7kDoMoPSiO4KsDJoHLWsVIH05nBd4GCqrE /Hs/McN9zb4OF81PXb8OOlgLGr7gGgkdKl5kXy22gIHKsrb0/xTqRCgmgvOjaicLcwK5 u1KR8ThBsXDXwlWXGmX2Awpr073df7VIxcCck2vN3oyLeCsf66OOTdsmdS4tVpNAczjC maRn+obuPrcVQXWv3Wcv1rSwUWJKLxYoMdmqCbyC2myoN5FjiX/UrHdviy5PSUEcAFIG WNrnkiuomvaEeip0tfIdxK18e692OVUUpu9kW8oquqJChMACK3c/84sX8W/IOYHyThcT Gu6w== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QED/SSGq+wjGiUC4kV1cX92EW4mFvNjTRB" X-RZG-CLASS-ID: mo00 Received: from sender by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id 20735bvA7DmxlOo (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 7 Nov 2019 14:48:59 +0100 (CET) Date: Thu, 7 Nov 2019 14:48:50 +0100 From: Olaf Hering To: Vitaly Kuznetsov Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Sasha Levin , "open list\:Hyper-V CORE AND DRIVERS" , open list Subject: Re: [PATCH v1] tools/hv: async name resolution in kvp_daemon Message-ID: <20191107144850.37587edb.olaf@aepfle.de> In-Reply-To: <874kzfbybk.fsf@vitty.brq.redhat.com> References: <20191024144943.26199-1-olaf@aepfle.de> <874kzfbybk.fsf@vitty.brq.redhat.com> X-Mailer: Claws Mail 2019.05.18 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/TfRDKLn+ytyQpDe=3EHiVfq"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/TfRDKLn+ytyQpDe=3EHiVfq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 07 Nov 2019 14:39:11 +0100 schrieb Vitaly Kuznetsov : > Olaf Hering writes: > Is it only EAI_AGAIN or do you see any other return values which justify > the retry? I'm afraid that in case of a e.g. non-existing hostname we'll > be infinitely looping with EAI_FAIL. I currently do not have a setup that reproduces the failure. I think if this thread loops forever, so be it. The report I have shows "getaddrinfo failed: 0xfffffffe Name or service not= known" on the host side. And that went away within the VM once "networking was fixed", whatever this= means. But hv_kvp_daemon would report the error string forever. > > + pthread_detach(t); =20 > I think this should be complemented with pthread_cancel/pthread_join > before exiting main(). If the thread is detached, it is exactly that: detached. Why do you think t= he main thread should wait for the detached thread? Olaf --Sig_/TfRDKLn+ytyQpDe=3EHiVfq Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAl3EIMIACgkQ86SN7mm1 DoDUzxAAoj3rIvo4UnuYA6gdsJXo/4gzx1ef87gMMUDuTYvUerULqG3HqC0PbzWg T7nX3L8MqHDqTJ3NhZyIuicIqGub5HfwnzQDnTMS/1PIW/t0tkiVbFbnXyYaRx9B wC8aJLxpaR6NT4XCqq1HMv1zF2fr329phf3kFOPRONGwRoh1ACgk8N9cVnK6Wakl SCXWvXxaUtpt5I3A9UQUmQUSDDtv2+DrHiJctWfVZR2ZW2EVSeCNqMVJS4ZyF6Fo WMPCnb/5zLlLYo204jlsdEB9ny/FgKrLhjQeuEO2Mt+qBXK//Rz79jRQLhKB1EpV NrIpSgZ2PJAmnKRXVoKhqDo6CkPHmCbZFlWHGbmaRg9b5tQpY2cTiZI/4UgM8IIm ogFuGEFAM7uWC+iPKgf/apAofMmNoL/8YHwThlgCptHZZotaZu/FdFHnUT1mYSY/ BsfFqhjjNKFkiy4J0GubudeCyKCyiIQ+aQ3inXDCJF3Mh2EbV4MMGIkzy9BqjCG3 pnmv5kcSXiuUv4r/KGBS0L+JD9D9cAQcF2arbs/YR4U20WbMQb+WHQmZgfKmjW9u hLvAPIQSvkt6SJOVhqxUtC+YpuNp8gn+muX2SeTVFhIzYUhDwRUKdwGA/vcYeD+O NT2FTV4m6T68jhRCWT1EcvAYztABDp8g9mhn2KJYvssbbstKIpk= =A5vV -----END PGP SIGNATURE----- --Sig_/TfRDKLn+ytyQpDe=3EHiVfq--