From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73AABC43331 for ; Thu, 7 Nov 2019 19:02:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BC9C21D6C for ; Thu, 7 Nov 2019 19:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573153368; bh=vSMWFiPzy7GqjBffiH5TKzLCEoSGGOHF1z2VqTV39SI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tbe5h2z7Vj64ID9sEnLQ+OPw9g2Mz6oB8QabaQWCV+tytTWpFBN52lrHGhrFo5QPQ 4b043dJvmo13mLL3IBcjVJNz6W3G7in9fd22A1H9ytYYTDWR+drJg+oUstEpFwg/aI r4Lm/p9PNcjnztv/qkRzy52kdqV7LlWreXAM8v0E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729014AbfKGTCr (ORCPT ); Thu, 7 Nov 2019 14:02:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:41902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbfKGTCq (ORCPT ); Thu, 7 Nov 2019 14:02:46 -0500 Received: from quaco.ghostprotocols.net (179-240-172-58.3g.claro.net.br [179.240.172.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39E98218AE; Thu, 7 Nov 2019 19:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573153365; bh=vSMWFiPzy7GqjBffiH5TKzLCEoSGGOHF1z2VqTV39SI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nWHzeivmAyGgD24ksKpOKOvEz1pHfk1rgNxoUJcx8CTlmBdPNeSXaPVwGx3xAZVNo 353hnA61bR/dePJqkAwbykzscmZINYxO7W5yR4vUBVP9hz8NHtFWT6HuCmMMvDuTOJ 7ZND7LVPTVzbAr+wzPk4TcCEm98VmOSYFwXTTfmo= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Masami Hiramatsu , Jiri Olsa , Arnaldo Carvalho de Melo Subject: [PATCH 15/63] perf probe: Fix to find range-only function instance Date: Thu, 7 Nov 2019 15:59:23 -0300 Message-Id: <20191107190011.23924-16-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191107190011.23924-1-acme@kernel.org> References: <20191107190011.23924-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masami Hiramatsu Fix die_is_func_instance() to find range-only function instance. In some case, a function instance can be made without any low PC or entry PC, but only with address ranges by optimization. (e.g. cold text partially in "text.unlikely" section) To find such function instance, we have to check the range attribute too. Fixes: e1ecbbc3fa83 ("perf probe: Fix to handle optimized not-inlined functions") Signed-off-by: Masami Hiramatsu Cc: Jiri Olsa Cc: Namhyung Kim Link: http://lore.kernel.org/lkml/157190835669.1859.8368628035930950596.stgit@devnote2 Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/dwarf-aux.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c index df6cee5c071f..2ec24c3bed44 100644 --- a/tools/perf/util/dwarf-aux.c +++ b/tools/perf/util/dwarf-aux.c @@ -318,10 +318,14 @@ bool die_is_func_def(Dwarf_Die *dw_die) bool die_is_func_instance(Dwarf_Die *dw_die) { Dwarf_Addr tmp; + Dwarf_Attribute attr_mem; /* Actually gcc optimizes non-inline as like as inlined */ - return !dwarf_func_inline(dw_die) && dwarf_entrypc(dw_die, &tmp) == 0; + return !dwarf_func_inline(dw_die) && + (dwarf_entrypc(dw_die, &tmp) == 0 || + dwarf_attr(dw_die, DW_AT_ranges, &attr_mem) != NULL); } + /** * die_get_data_member_location - Get the data-member offset * @mb_die: a DIE of a member of a data structure -- 2.21.0