From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, lizefan@huawei.com,
hannes@cmpxchg.org, kernel-team@fb.com
Subject: [PATCHSET v2 block/for-next] blk-cgroup: use cgroup rstat for IO stats
Date: Thu, 7 Nov 2019 11:17:58 -0800 [thread overview]
Message-ID: <20191107191804.3735303-1-tj@kernel.org> (raw)
Hello,
v2: Build fix when !DEBUG.
blk-cgroup IO stats currently use blkg_rwstat which unforutnately
requires walking all descendants recursively on read. On systems with
a large number of cgroups (dead or alive), this can make each stat
read a substantially expensive operation.
This patch updates blk-cgroup to use cgroup rstat which makes stat
reading O(# descendants which have been active since last reading)
instead of O(# descendants).
0001-bfq-iosched-relocate-bfqg_-rwstat-helpers.patch
0002-bfq-iosched-stop-using-blkg-stat_bytes-and-stat_ios.patch
0003-blk-throtl-stop-using-blkg-stat_bytes-and-stat_ios.patch
0004-blk-cgroup-remove-now-unused-blkg_print_stat_-bytes-.patch
0005-blk-cgroup-reimplement-basic-IO-stats-using-cgroup-r.patch
0006-blk-cgroup-separate-out-blkg_rwstat-under-CONFIG_BLK.patch
0001-0003 make bfq-iosched and blk-throtl use their own blkg_rwstat to
track basic IO stats on cgroup1 instead of sharing blk-cgroup core's.
0004 is a follow-up cleanup.
0005 switches blk-cgroup to cgroup rstat.
0006 moves blkg_rwstat to its own files and gate it under a config
option as it's now only used by blk-throtl and bfq-iosched.
The patchset is on top of
block/for-next 40afbe18b03a ("Merge branch 'for-5.5/drivers-post' into for-next")
+ block/for-linus b0814361a25c ("blkcg: make blkcg_print_stat() print stats only for online blkgs")
and also available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-blkcg-rstat
Thanks.
block/Kconfig | 4
block/Kconfig.iosched | 1
block/Makefile | 1
block/bfq-cgroup.c | 37 +++--
block/bfq-iosched.c | 4
block/bfq-iosched.h | 6
block/blk-cgroup-rwstat.c | 129 +++++++++++++++++++
block/blk-cgroup-rwstat.h | 149 ++++++++++++++++++++++
block/blk-cgroup.c | 304 ++++++++++++++-------------------------------
block/blk-throttle.c | 71 +++++++++-
include/linux/blk-cgroup.h | 198 +++++------------------------
11 files changed, 517 insertions(+), 387 deletions(-)
--
tejun
[1] http://lkml.kernel.org/r/20191105160951.GS3622521@devbig004.ftw2.facebook.com
next reply other threads:[~2019-11-07 19:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 19:17 Tejun Heo [this message]
2019-11-07 19:17 ` [PATCH 1/6] bfq-iosched: relocate bfqg_*rwstat*() helpers Tejun Heo
2019-11-07 19:18 ` [PATCH 2/6] bfq-iosched: stop using blkg->stat_bytes and ->stat_ios Tejun Heo
2019-11-07 19:18 ` [PATCH 3/6] blk-throtl: " Tejun Heo
2019-11-07 19:18 ` [PATCH 4/6] blk-cgroup: remove now unused blkg_print_stat_{bytes|ios}_recursive() Tejun Heo
2019-11-07 19:18 ` [PATCH 5/6] blk-cgroup: reimplement basic IO stats using cgroup rstat Tejun Heo
2019-11-13 11:13 ` Faiz Abbas
2019-11-13 16:35 ` Tejun Heo
2019-11-14 12:17 ` Ionela Voinescu
2019-11-14 22:31 ` [PATCH block/for-next] blk-cgroup: cgroup_rstat_updated() shouldn't be called on cgroup1 Tejun Heo
2019-11-18 8:39 ` Faiz Abbas
2019-11-18 15:41 ` Jens Axboe
2019-11-07 19:18 ` [PATCH 6/6] blk-cgroup: separate out blkg_rwstat under CONFIG_BLK_CGROUP_RWSTAT Tejun Heo
2019-11-07 19:28 ` [PATCHSET v2 block/for-next] blk-cgroup: use cgroup rstat for IO stats Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107191804.3735303-1-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).