From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B7DC43331 for ; Thu, 7 Nov 2019 22:14:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 510C12075C for ; Thu, 7 Nov 2019 22:14:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Mp83Scxe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbfKGWOk (ORCPT ); Thu, 7 Nov 2019 17:14:40 -0500 Received: from mail-pg1-f201.google.com ([209.85.215.201]:49058 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfKGWOj (ORCPT ); Thu, 7 Nov 2019 17:14:39 -0500 Received: by mail-pg1-f201.google.com with SMTP id q20so2977143pgj.15 for ; Thu, 07 Nov 2019 14:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=omy25HIHX5dmo9XLEd3IHF2hKxH2v3SOwm2huLFaCk0=; b=Mp83Scxe/sdzwo5wo5Jjh7FQgGP5b908yU23n1+o24ddFtRsO3CfPaTZBnW9isGEAf QjZyUketnuzTkeJVyfQK0CnYJFjwtKE3+3zAWQWIZoPGHqt0nzuJOM7Mbtl5z9JkYONB g4vXneS0uuWiKhHcZabafO2Lz9+cWZrt7oAq8UsZOc58taqdsgR3TGhQJ/E4U7VZlkHH QFNGBctK4vllT/Obpkf6fPmn+Rrs2uhgEDxc6FTbCH/p8ikg5KdRJ9QwIXKyTNSJYcKj UbctAIbMu/zH3zoBgsj3uEI+ZyN5IqsTjWHMdYN1Ss0Un4ffQam0qZsDF6mI0soilsEv oHmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=omy25HIHX5dmo9XLEd3IHF2hKxH2v3SOwm2huLFaCk0=; b=FIgHHcXi5uRWvSGe1Ec0M5kQL4uKn1fvq/xNQgJ546fH85oOymEUt+vtZnvvS3+mR3 6n/So6g/WqYpS3RKWZ7JRBsIv7aPn3KGmZdre+6jfsfRpWcDdtLJqjQy6r4ZSlZ6kMMt H5B/0ijHdWETkTxBE2sHcZ+8bEFIr2+fcg6N81xtjaaMq4f6IGfkK5tuT86lnP8mdY8F G0igs+01pgQi2CGykRTcgW0TBNOAOsp96jo7fPFgYi+2msoIW3/hulqdrx7hB1zohXHI 8E98LnDDW+h9JUbXiSqNTIUijfUJQdD3FlBY40FshJ/L4LOzmodIrNWtY4UWi9GaiUQx 5eLg== X-Gm-Message-State: APjAAAWWyhY+1lXfLSc5WqjPomHcbEUQzJhfzd3CkVtC1lqbO7S9QQvB e51qKjNcAc+qZAuZCAuaI4yD1qSyzfG9 X-Google-Smtp-Source: APXvYqyrd5Cfjge5xILVt6mmEuqts4fEL98RfVNnYcg0T/W+FZno73A7rz4q/+uwquBUYqzIWPesZctI/53D X-Received: by 2002:a63:e241:: with SMTP id y1mr7746140pgj.427.1573164878525; Thu, 07 Nov 2019 14:14:38 -0800 (PST) Date: Thu, 7 Nov 2019 14:14:18 -0800 In-Reply-To: <20191030223448.12930-1-irogers@google.com> Message-Id: <20191107221428.168286-1-irogers@google.com> Mime-Version: 1.0 References: <20191030223448.12930-1-irogers@google.com> X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog Subject: [PATCH v6 00/10] Improvements to memory usage by parse events From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andi Kleen , Jin Yao , Adrian Hunter , Kan Liang , John Garry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The parse events parser leaks memory for certain expressions as well as allowing a char* to reference stack, heap or .rodata. This series of patches improves the hygeine and adds free-ing operations to reclaim memory in the parser in error and non-error situations. The series of patches was generated with LLVM's address sanitizer and libFuzzer: https://llvm.org/docs/LibFuzzer.html called on the parse_events function with randomly generated input. With the patches no leaks or memory corruption issues were present. The v6 patches address a C90 compilation issue. The v5 patches add initial error print to the set, as requested by Jiri Olsa. They also fix additional 2 missed frees in the patch 'before yyabort-ing free components' and remove a redundant new_str variable from the patch 'add parse events handle error' as spotted by Stephane Eranian. The v4 patches address review comments from Jiri Olsa, turning a long error message into a single warning, fixing the data type in a list iterator and reordering patches. The v3 patches address review comments from Jiri Olsa improving commit messages, handling ENOMEM errors from strdup better, and removing a printed warning if an invalid event is passed. The v2 patches are preferable to an earlier proposed patch: perf tools: avoid reading out of scope array Ian Rogers (10): perf tools: add parse events handle error perf tools: move ALLOC_LIST into a function perf tools: avoid a malloc for array events perf tools: splice events onto evlist even on error perf tools: ensure config and str in terms are unique perf tools: add destructors for parse event terms perf tools: before yyabort-ing free components perf tools: if pmu configuration fails free terms perf tools: add a deep delete for parse event terms perf tools: report initial event parsing error tools/perf/arch/powerpc/util/kvm-stat.c | 9 +- tools/perf/builtin-stat.c | 2 + tools/perf/builtin-trace.c | 16 +- tools/perf/tests/parse-events.c | 3 +- tools/perf/util/metricgroup.c | 2 +- tools/perf/util/parse-events.c | 239 +++++++++++---- tools/perf/util/parse-events.h | 7 + tools/perf/util/parse-events.y | 390 +++++++++++++++++------- tools/perf/util/pmu.c | 32 +- 9 files changed, 511 insertions(+), 189 deletions(-) -- 2.24.0.432.g9d3f5f5b63-goog