From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: megous@megous.com, mark.rutland@arm.com,
devicetree@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
mripard@kernel.org, kishon@ti.com, paul.kocialkowski@bootlin.com,
linux-sunxi@googlegroups.com, robh+dt@kernel.org,
tglx@linutronix.de, wens@csie.org,
linux-arm-kernel@lists.infradead.org, icenowy@aosc.io
Subject: Re: [PATCH] phy: allwinner: Fix GENMASK misuse
Date: Thu, 7 Nov 2019 23:39:14 +0000 [thread overview]
Message-ID: <20191107233914.GW25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191107204645.13739-1-rikard.falkeborn@gmail.com>
On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote:
> Arguments are supposed to be ordered high then low.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> Spotted while trying to add compile time checks of GENMASK arguments.
> Patch has only been compile tested.
My feeling, personally, is that GENMASK() really isn't worth the pain
it causes. Can we instead get rid of this thing and just use easier
to understand and less error-prone hex masks please?
I don't care what anyone else says, personally I'm going to stick with
using hex masks as I find them way easier to get right first time than
a problematical opaque macro - and I really don't want the effort of
finding out that I've got the arguments wrong when I build it. It's
just _way_ easier and less error prone to use a hex mask straight off.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-11-07 23:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 13:42 [PATCH 0/4] Add USB 3 support for H6 and Orange Pi 3 megous
2019-10-20 13:42 ` [PATCH 1/4] dt-bindings: Add bindings for USB3 phy on Allwinner H6 megous
2019-10-21 11:06 ` Maxime Ripard
2019-10-20 13:42 ` [PATCH 2/4] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC megous
2019-10-21 11:08 ` Maxime Ripard
2019-11-07 20:46 ` [PATCH] phy: allwinner: Fix GENMASK misuse Rikard Falkeborn
2019-11-07 21:45 ` Ondřej Jirman
2019-11-08 11:29 ` Icenowy Zheng
2019-11-08 11:41 ` Ondřej Jirman
2019-11-08 11:43 ` Ondřej Jirman
2019-11-07 23:39 ` Russell King - ARM Linux admin [this message]
2019-11-08 1:46 ` Joe Perches
2019-11-08 8:29 ` Paul Kocialkowski
2019-11-10 12:43 ` [PATCH v2] " Rikard Falkeborn
2019-11-24 22:10 ` Rikard Falkeborn
2019-12-09 20:18 ` Rikard Falkeborn
2020-02-23 3:23 ` [linux-sunxi] [PATCH v2 RESEND] " Chen-Yu Tsai
2020-02-24 9:18 ` Maxime Ripard
2019-10-20 13:42 ` [PATCH 3/4] arm64: dts: allwinner: h6: add USB3 device nodes megous
2019-10-20 13:42 ` [PATCH 4/4] arm64: dts: allwinner: orange-pi-3: Enable USB 3.0 host support megous
2019-10-21 11:09 ` Maxime Ripard
2019-11-04 12:16 ` Ondřej Jirman
2019-11-05 10:45 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107233914.GW25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=icenowy@aosc.io \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=rikard.falkeborn@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).