* [PATCH] tcp: remove redundant new line from tcp_event_sk_skb
@ 2019-11-08 9:50 Tony Lu
2019-11-08 12:22 ` Eric Dumazet
2019-11-08 12:43 ` Yafang Shao
0 siblings, 2 replies; 4+ messages in thread
From: Tony Lu @ 2019-11-08 9:50 UTC (permalink / raw)
To: edumazet, rostedt, mingo; +Cc: netdev, linux-kernel
This removes '\n' from trace event class tcp_event_sk_skb to avoid
redundant new blank line and make output compact.
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
---
include/trace/events/tcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 2bc9960a31aa..cf97f6339acb 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
),
- TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
+ TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
__entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
__entry->saddr_v6, __entry->daddr_v6,
show_tcp_state_name(__entry->state))
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tcp: remove redundant new line from tcp_event_sk_skb
2019-11-08 9:50 [PATCH] tcp: remove redundant new line from tcp_event_sk_skb Tony Lu
@ 2019-11-08 12:22 ` Eric Dumazet
2019-11-09 10:34 ` Tony Lu
2019-11-08 12:43 ` Yafang Shao
1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2019-11-08 12:22 UTC (permalink / raw)
To: Tony Lu, edumazet, rostedt, mingo; +Cc: netdev, linux-kernel, Yafang Shao
On 11/8/19 1:50 AM, Tony Lu wrote:
> This removes '\n' from trace event class tcp_event_sk_skb to avoid
> redundant new blank line and make output compact.
>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> include/trace/events/tcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> index 2bc9960a31aa..cf97f6339acb 100644
> --- a/include/trace/events/tcp.h
> +++ b/include/trace/events/tcp.h
> @@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
> sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
> ),
>
> - TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
> + TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
> __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
> __entry->saddr_v6, __entry->daddr_v6,
> show_tcp_state_name(__entry->state))
>
This seems good to me. Only few comments :
I would add a
Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
And also CC (I just did in this reply) the author of the above patch to make sure nothing unexpected happens.
Thanks.
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tcp: remove redundant new line from tcp_event_sk_skb
2019-11-08 12:22 ` Eric Dumazet
@ 2019-11-09 10:34 ` Tony Lu
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lu @ 2019-11-09 10:34 UTC (permalink / raw)
To: Eric Dumazet; +Cc: edumazet, rostedt, mingo, netdev, linux-kernel, Yafang Shao
Thanks for your comments, I am going to append the tag.
Cheers,
Tony Lu
On Fri, Nov 08, 2019 at 04:22:19AM -0800, Eric Dumazet wrote:
>
>
> On 11/8/19 1:50 AM, Tony Lu wrote:
> > This removes '\n' from trace event class tcp_event_sk_skb to avoid
> > redundant new blank line and make output compact.
> >
> > Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> > ---
> > include/trace/events/tcp.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> > index 2bc9960a31aa..cf97f6339acb 100644
> > --- a/include/trace/events/tcp.h
> > +++ b/include/trace/events/tcp.h
> > @@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
> > sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
> > ),
> >
> > - TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
> > + TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
> > __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
> > __entry->saddr_v6, __entry->daddr_v6,
> > show_tcp_state_name(__entry->state))
> >
>
> This seems good to me. Only few comments :
>
> I would add a
>
> Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
>
> And also CC (I just did in this reply) the author of the above patch to make sure nothing unexpected happens.
>
> Thanks.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tcp: remove redundant new line from tcp_event_sk_skb
2019-11-08 9:50 [PATCH] tcp: remove redundant new line from tcp_event_sk_skb Tony Lu
2019-11-08 12:22 ` Eric Dumazet
@ 2019-11-08 12:43 ` Yafang Shao
1 sibling, 0 replies; 4+ messages in thread
From: Yafang Shao @ 2019-11-08 12:43 UTC (permalink / raw)
To: Tony Lu; +Cc: Eric Dumazet, Steven Rostedt, mingo, netdev, LKML
On Fri, Nov 8, 2019 at 6:12 PM Tony Lu <tonylu@linux.alibaba.com> wrote:
>
> This removes '\n' from trace event class tcp_event_sk_skb to avoid
> redundant new blank line and make output compact.
>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
Thanks for pointing this out.
Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
> ---
> include/trace/events/tcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> index 2bc9960a31aa..cf97f6339acb 100644
> --- a/include/trace/events/tcp.h
> +++ b/include/trace/events/tcp.h
> @@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
> sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
> ),
>
> - TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
> + TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
> __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
> __entry->saddr_v6, __entry->daddr_v6,
> show_tcp_state_name(__entry->state))
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-09 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08 9:50 [PATCH] tcp: remove redundant new line from tcp_event_sk_skb Tony Lu
2019-11-08 12:22 ` Eric Dumazet
2019-11-09 10:34 ` Tony Lu
2019-11-08 12:43 ` Yafang Shao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).