* [PATCH] rpmsg: char: Simplify 'rpmsg_eptdev_release()'
@ 2019-10-29 6:09 Christophe JAILLET
2019-11-09 0:50 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2019-10-29 6:09 UTC (permalink / raw)
To: ohad, bjorn.andersson
Cc: linux-remoteproc, linux-kernel, kernel-janitors, Christophe JAILLET
Use 'skb_queue_purge()' instead of re-implementing it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/rpmsg/rpmsg_char.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
index 507bfe163883..0c3a340db7d1 100644
--- a/drivers/rpmsg/rpmsg_char.c
+++ b/drivers/rpmsg/rpmsg_char.c
@@ -146,7 +146,6 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp)
{
struct rpmsg_eptdev *eptdev = cdev_to_eptdev(inode->i_cdev);
struct device *dev = &eptdev->dev;
- struct sk_buff *skb;
/* Close the endpoint, if it's not already destroyed by the parent */
mutex_lock(&eptdev->ept_lock);
@@ -157,10 +156,7 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp)
mutex_unlock(&eptdev->ept_lock);
/* Discard all SKBs */
- while (!skb_queue_empty(&eptdev->queue)) {
- skb = skb_dequeue(&eptdev->queue);
- kfree_skb(skb);
- }
+ skb_queue_purge(&eptdev->queue);
put_device(dev);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rpmsg: char: Simplify 'rpmsg_eptdev_release()'
2019-10-29 6:09 [PATCH] rpmsg: char: Simplify 'rpmsg_eptdev_release()' Christophe JAILLET
@ 2019-11-09 0:50 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-11-09 0:50 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: ohad, linux-remoteproc, linux-kernel, kernel-janitors
On Mon 28 Oct 23:09 PDT 2019, Christophe JAILLET wrote:
> Use 'skb_queue_purge()' instead of re-implementing it.
>
Applied, thanks.
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/rpmsg/rpmsg_char.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> index 507bfe163883..0c3a340db7d1 100644
> --- a/drivers/rpmsg/rpmsg_char.c
> +++ b/drivers/rpmsg/rpmsg_char.c
> @@ -146,7 +146,6 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp)
> {
> struct rpmsg_eptdev *eptdev = cdev_to_eptdev(inode->i_cdev);
> struct device *dev = &eptdev->dev;
> - struct sk_buff *skb;
>
> /* Close the endpoint, if it's not already destroyed by the parent */
> mutex_lock(&eptdev->ept_lock);
> @@ -157,10 +156,7 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp)
> mutex_unlock(&eptdev->ept_lock);
>
> /* Discard all SKBs */
> - while (!skb_queue_empty(&eptdev->queue)) {
> - skb = skb_dequeue(&eptdev->queue);
> - kfree_skb(skb);
> - }
> + skb_queue_purge(&eptdev->queue);
>
> put_device(dev);
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-09 0:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 6:09 [PATCH] rpmsg: char: Simplify 'rpmsg_eptdev_release()' Christophe JAILLET
2019-11-09 0:50 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).