[PATCH v2 0/2] Support reboot power-off driver as module

[PATCH v2 0/2] Support reboot power-off driver as module

[Elliot Berman]

This series supports reboot power-off driver as a module by exporting
reboot_mode symbol.

Changes since V1:
 - EXPORT_SYMBOL -> EXPORT_SYMBOL_GPL

Elliot Berman (2):
  reboot: Export reboot_mode
  power: reset: Enable tristate on restart power-off driver

 drivers/power/reset/Kconfig | 2 +-
 kernel/reboot.c             | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH v2 1/2] reboot: Export reboot_mode

[Elliot Berman]

Export reboot_mode to support kernel modules wishing to modify reboot_mode.

Signed-off-by: Elliot Berman <eberman@codeaurora.org>
---
 kernel/reboot.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/reboot.c b/kernel/reboot.c
index c4d472b..b1fbc22 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -32,7 +32,9 @@ EXPORT_SYMBOL(cad_pid);
 #define DEFAULT_REBOOT_MODE
 #endif
 enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
+EXPORT_SYMBOL_GPL(reboot_mode);
 enum reboot_mode panic_reboot_mode = REBOOT_UNDEFINED;
+EXPORT_SYMBOL_GPL(panic_reboot_mode);
 
 /*
  * This variable is used privately to keep track of whether or not
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH v2 1/2] reboot: Export reboot_mode

[Bjorn Andersson]

On Fri 08 Nov 15:40 PST 2019, Elliot Berman wrote:

> Export reboot_mode to support kernel modules wishing to modify reboot_mode.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> ---
>  kernel/reboot.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index c4d472b..b1fbc22 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -32,7 +32,9 @@ EXPORT_SYMBOL(cad_pid);
>  #define DEFAULT_REBOOT_MODE
>  #endif
>  enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
> +EXPORT_SYMBOL_GPL(reboot_mode);
>  enum reboot_mode panic_reboot_mode = REBOOT_UNDEFINED;
> +EXPORT_SYMBOL_GPL(panic_reboot_mode);
>  
>  /*
>   * This variable is used privately to keep track of whether or not
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

Re: [PATCH v2 1/2] reboot: Export reboot_mode

[Greg KH]

On Fri, Nov 08, 2019 at 03:40:51PM -0800, Elliot Berman wrote:
> Export reboot_mode to support kernel modules wishing to modify reboot_mode.
> 
> Signed-off-by: Elliot Berman <eberman@codeaurora.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH v2 1/2] reboot: Export reboot_mode

[Greg Kroah-Hartman]

On Mon, May 24, 2021 at 01:09:18PM +0100, Lee Jones wrote:
> On Fri, 8 Nov 2019 at 23:41, Elliot Berman <eberman@codeaurora.org> wrote:
> 
> > Export reboot_mode to support kernel modules wishing to modify reboot_mode.
> >
> > Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> > ---
> >  kernel/reboot.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> 
> Reviewed by Bjorn and GregKH, but never merged.
> 
> I guess all the parties are still solving this downstream.
> 
> Andrew, is this still something you'd consider?

If there is no in-kernel user, it does not need to be exported.

thanks,

greg k-h

Re: [PATCH v2 1/2] reboot: Export reboot_mode

[Bjorn Andersson]

On Mon 24 May 07:09 CDT 2021, Lee Jones wrote:

> On Fri, 8 Nov 2019 at 23:41, Elliot Berman <eberman@codeaurora.org> wrote:
> 
> > Export reboot_mode to support kernel modules wishing to modify reboot_mode.
> >
> > Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> > ---
> >  kernel/reboot.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> 
> Reviewed by Bjorn and GregKH, but never merged.
> 
> I guess all the parties are still solving this downstream.
> 
> Andrew, is this still something you'd consider?
> 

Seems more reasonable that it would go together with patch 2, which
Sebastian pointed out doesn't build.

Regards,
Bjorn

> diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index c4d472b..b1fbc22 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -32,7 +32,9 @@ EXPORT_SYMBOL(cad_pid);
> >  #define DEFAULT_REBOOT_MODE
> >  #endif
> >  enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
> > +EXPORT_SYMBOL_GPL(reboot_mode);
> >  enum reboot_mode panic_reboot_mode = REBOOT_UNDEFINED;
> > +EXPORT_SYMBOL_GPL(panic_reboot_mode);
> >
> >  /*
> >   * This variable is used privately to keep track of whether or not
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
> >
> 
> -- 
> Lee Jones [?????????]
> Linaro Services Senior Technical Lead
> Linaro.org ??? Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

[PATCH v2 2/2] power: reset: Enable tristate on restart power-off driver

[Elliot Berman]

Since reboot_mode is an exported symbol, restart power-off driver can be
compiled as module.

Signed-off-by: Elliot Berman <eberman@codeaurora.org>
---
 drivers/power/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index a564237..8db1d9d 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -150,7 +150,7 @@ config POWER_RESET_QNAP
 	  Say Y if you have a QNAP NAS.
 
 config POWER_RESET_RESTART
-	bool "Restart power-off driver"
+	tristate "Restart power-off driver"
 	help
 	  Some boards don't actually have the ability to power off.
 	  Instead they restart, and u-boot holds the SoC until the
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH v2 2/2] power: reset: Enable tristate on restart power-off driver

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi,

On Fri, Nov 08, 2019 at 03:40:52PM -0800, Elliot Berman wrote:
> Since reboot_mode is an exported symbol, restart power-off driver can be
> compiled as module.
> 
> Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> ---

I tried applying this for 5.6, but it fails to build with
allmodconfig on arm:

ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined!

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]