From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC655C43331 for ; Sat, 9 Nov 2019 19:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A64F121882 for ; Sat, 9 Nov 2019 19:17:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lkiCeald" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbfKITRx (ORCPT ); Sat, 9 Nov 2019 14:17:53 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33453 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfKITRu (ORCPT ); Sat, 9 Nov 2019 14:17:50 -0500 Received: by mail-pg1-f196.google.com with SMTP id h27so6354347pgn.0 for ; Sat, 09 Nov 2019 11:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TMGL0/JOFpPqKkGlrsxqclkHeaNLkWbgoH9TNGWPKSw=; b=lkiCealdzclaVAPsevr74tOpi5JiABXIsPgU1ZVyWip88uN0+FOgeLeKvj1vc4lJJ9 FT0x0EoErJL5QQFJC5uWygVLO7Sex5+OJk+TbBSgzROcaOM9R/NSkTexwy+x9ekor8mP egLHNr2ujeun+0/0VYIG8MRz1J0x379phIBME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TMGL0/JOFpPqKkGlrsxqclkHeaNLkWbgoH9TNGWPKSw=; b=ryvoT5Yh6takVu7lHBHGHddgWeoQjnQHU+Hnr5lc2G3vvmTFNowPSpnfJWALHuXP4e kBKs3UM+z+12ikIrHks9Yg9WZdoAnEnIhmdHR8DJHawc6Iqjl0vM9DMEIOV7U+Pnc6dM ZEJhdh1Ba41R++6ZI6TCkRxCbBK45TpCgTLoPzdo0XNzRLsiKHfCW0/kSrebk3IHRh9e rGRwDo5BWdWsIF85P2pmvNYlFDsJuTOtAGCzx0cP+GwntSDTqvotxhjbujlvfQJii7ah VjbqfUPrFGvkMF/CuMMnkj3rd8RGfHPAgKPb6i4yAZv6m+0MHJlQ4R4mzrCnW95SkFkm i1Xg== X-Gm-Message-State: APjAAAXm97TeaajbI7cvaZVbMjO5i6Uf53z6M6AXrEGMJ7Oy4L3Rrior g7IgH9+PCkyWru91wt4nSosCJg== X-Google-Smtp-Source: APXvYqxnQkGYhPWPn3X9DGYKlVL1PWVPD0psI26vKilAG8d5p0YT0qXbyIrrGS21pCS3WIFLhz/pnA== X-Received: by 2002:a63:e84d:: with SMTP id a13mr19382177pgk.226.1573327069085; Sat, 09 Nov 2019 11:17:49 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id i11sm9193577pgd.7.2019.11.09.11.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2019 11:17:48 -0800 (PST) From: Douglas Anderson To: Paul Burton , Jason Wessel , Daniel Thompson Cc: qiaochong@loongson.cn, kgdb-bugreport@lists.sourceforge.net, ralf@linux-mips.org, Douglas Anderson , Sebastian Andrzej Siewior , James Hogan , Mike Rapoport , "Eric W. Biederman" , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Serge Semin , Andrew Morton Subject: [PATCH 1/5] MIPS: kdb: Remove old workaround for backtracing on other CPUs Date: Sat, 9 Nov 2019 11:16:40 -0800 Message-Id: <20191109111623.1.I30a0cac4d9880040c8d41495bd9a567fe3e24989@changeid> X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog In-Reply-To: <20191109191644.191766-1-dianders@chromium.org> References: <20191109191644.191766-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As of commit 2277b492582d ("kdb: Fix stack crawling on 'running' CPUs that aren't the master") we no longer need any special case for doing stack dumps on CPUs that are not the kdb master. Let's remove. Signed-off-by: Douglas Anderson --- I have no way to test this personally, so hopefully someone who uses kdb/kgdb on MIPS can. Ideally this patch should be Acked by MIPS folks and then land through the kdb/kgdb tree since the next patch in the series, ("kdb: kdb_current_regs should be private") depends on it. arch/mips/kernel/traps.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c index 342e41de9d64..46fbcfeaae9a 100644 --- a/arch/mips/kernel/traps.c +++ b/arch/mips/kernel/traps.c @@ -210,11 +210,6 @@ void show_stack(struct task_struct *task, unsigned long *sp) regs.regs[29] = task->thread.reg29; regs.regs[31] = 0; regs.cp0_epc = task->thread.reg31; -#ifdef CONFIG_KGDB_KDB - } else if (atomic_read(&kgdb_active) != -1 && - kdb_current_regs) { - memcpy(®s, kdb_current_regs, sizeof(regs)); -#endif /* CONFIG_KGDB_KDB */ } else { prepare_frametrace(®s); } -- 2.24.0.432.g9d3f5f5b63-goog