* [PATCH 0/2] iio: adc: stm32: add max clock rate @ 2019-10-28 16:11 Fabrice Gasnier 2019-10-28 16:11 ` [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property Fabrice Gasnier 2019-10-28 16:11 ` [PATCH 2/2] iio: adc: stm32: allow to tune analog clock Fabrice Gasnier 0 siblings, 2 replies; 7+ messages in thread From: Fabrice Gasnier @ 2019-10-28 16:11 UTC (permalink / raw) To: jic23, robh+dt Cc: alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, fabrice.gasnier, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel Add optional dt property to tune maximum desired analog clock rate. Fabrice Gasnier (2): dt-bindings: iio: stm32-adc: add max clock rate property iio: adc: stm32: allow to tune analog clock .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 2 ++ drivers/iio/adc/stm32-adc-core.c | 16 +++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property 2019-10-28 16:11 [PATCH 0/2] iio: adc: stm32: add max clock rate Fabrice Gasnier @ 2019-10-28 16:11 ` Fabrice Gasnier 2019-11-06 3:29 ` Rob Herring 2019-10-28 16:11 ` [PATCH 2/2] iio: adc: stm32: allow to tune analog clock Fabrice Gasnier 1 sibling, 1 reply; 7+ messages in thread From: Fabrice Gasnier @ 2019-10-28 16:11 UTC (permalink / raw) To: jic23, robh+dt Cc: alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, fabrice.gasnier, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel Add optional dt property to tune maximum desired analog clock rate. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> --- Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt index 4c0da8c..8de9331 100644 --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt @@ -53,6 +53,8 @@ Optional properties: analog input switches on stm32mp1. - st,syscfg: Phandle to system configuration controller. It can be used to control the analog circuitry on stm32mp1. +- st,max-clk-rate-hz: Allow to specify desired max clock rate used by analog + circuitry. Contents of a stm32 adc child node: ----------------------------------- -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property 2019-10-28 16:11 ` [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property Fabrice Gasnier @ 2019-11-06 3:29 ` Rob Herring 2019-11-09 12:36 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Rob Herring @ 2019-11-06 3:29 UTC (permalink / raw) To: Fabrice Gasnier Cc: jic23, robh+dt, alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, fabrice.gasnier, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel On Mon, 28 Oct 2019 17:11:47 +0100, Fabrice Gasnier wrote: > Add optional dt property to tune maximum desired analog clock rate. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > --- > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property 2019-11-06 3:29 ` Rob Herring @ 2019-11-09 12:36 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2019-11-09 12:36 UTC (permalink / raw) To: Rob Herring Cc: Fabrice Gasnier, robh+dt, alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel On Tue, 5 Nov 2019 21:29:17 -0600 Rob Herring <robh@kernel.org> wrote: > On Mon, 28 Oct 2019 17:11:47 +0100, Fabrice Gasnier wrote: > > Add optional dt property to tune maximum desired analog clock rate. > > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > > --- > > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Applied to the togreg branch of iio.git. Whether I get a pull request out for this cycle or this hits early in next is dependent on whether Linus hints at an rc8 and gives an extra week. Thanks, Jonathan ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] iio: adc: stm32: allow to tune analog clock 2019-10-28 16:11 [PATCH 0/2] iio: adc: stm32: add max clock rate Fabrice Gasnier 2019-10-28 16:11 ` [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property Fabrice Gasnier @ 2019-10-28 16:11 ` Fabrice Gasnier 2019-11-03 12:30 ` Jonathan Cameron 1 sibling, 1 reply; 7+ messages in thread From: Fabrice Gasnier @ 2019-10-28 16:11 UTC (permalink / raw) To: jic23, robh+dt Cc: alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, fabrice.gasnier, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel Add new optional dt property to tune analog clock prescaler. Driver looks for optional "st,max-clk-rate-hz", then computes best approximation below that rate, using ADC internal prescaler. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> --- drivers/iio/adc/stm32-adc-core.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c index 20c626c..6537f4f 100644 --- a/drivers/iio/adc/stm32-adc-core.c +++ b/drivers/iio/adc/stm32-adc-core.c @@ -79,6 +79,7 @@ struct stm32_adc_priv_cfg { * @domain: irq domain reference * @aclk: clock reference for the analog circuitry * @bclk: bus clock common for all ADCs, depends on part used + * @max_clk_rate: desired maximum clock rate * @booster: booster supply reference * @vdd: vdd supply reference * @vdda: vdda analog supply reference @@ -95,6 +96,7 @@ struct stm32_adc_priv { struct irq_domain *domain; struct clk *aclk; struct clk *bclk; + u32 max_clk_rate; struct regulator *booster; struct regulator *vdd; struct regulator *vdda; @@ -141,7 +143,7 @@ static int stm32f4_adc_clk_sel(struct platform_device *pdev, } for (i = 0; i < ARRAY_SIZE(stm32f4_pclk_div); i++) { - if ((rate / stm32f4_pclk_div[i]) <= priv->cfg->max_clk_rate_hz) + if ((rate / stm32f4_pclk_div[i]) <= priv->max_clk_rate) break; } if (i >= ARRAY_SIZE(stm32f4_pclk_div)) { @@ -230,7 +232,7 @@ static int stm32h7_adc_clk_sel(struct platform_device *pdev, if (ckmode) continue; - if ((rate / div) <= priv->cfg->max_clk_rate_hz) + if ((rate / div) <= priv->max_clk_rate) goto out; } } @@ -250,7 +252,7 @@ static int stm32h7_adc_clk_sel(struct platform_device *pdev, if (!ckmode) continue; - if ((rate / div) <= priv->cfg->max_clk_rate_hz) + if ((rate / div) <= priv->max_clk_rate) goto out; } @@ -655,6 +657,7 @@ static int stm32_adc_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct device_node *np = pdev->dev.of_node; struct resource *res; + u32 max_rate; int ret; if (!pdev->dev.of_node) @@ -731,6 +734,13 @@ static int stm32_adc_probe(struct platform_device *pdev) priv->common.vref_mv = ret / 1000; dev_dbg(&pdev->dev, "vref+=%dmV\n", priv->common.vref_mv); + ret = of_property_read_u32(pdev->dev.of_node, "st,max-clk-rate-hz", + &max_rate); + if (!ret) + priv->max_clk_rate = min(max_rate, priv->cfg->max_clk_rate_hz); + else + priv->max_clk_rate = priv->cfg->max_clk_rate_hz; + ret = priv->cfg->clk_sel(pdev, priv); if (ret < 0) goto err_hw_stop; -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: adc: stm32: allow to tune analog clock 2019-10-28 16:11 ` [PATCH 2/2] iio: adc: stm32: allow to tune analog clock Fabrice Gasnier @ 2019-11-03 12:30 ` Jonathan Cameron 2019-11-09 12:38 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Jonathan Cameron @ 2019-11-03 12:30 UTC (permalink / raw) To: Fabrice Gasnier Cc: robh+dt, alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel On Mon, 28 Oct 2019 17:11:48 +0100 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > Add new optional dt property to tune analog clock prescaler. > Driver looks for optional "st,max-clk-rate-hz", then computes > best approximation below that rate, using ADC internal prescaler. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> If the previous email I wrote on this got to anyone before I hit cancel, please ignore. Had completely failed to read the code correctly. Anyhow this seems fine to me, but given there are a lot of existing clk related bindings I'd like to give a little longer for Rob to have a chance to take a look at the binding. Give me a poke if I seem to have lost this in a week or so. Thanks, Jonathan > --- > drivers/iio/adc/stm32-adc-core.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c > index 20c626c..6537f4f 100644 > --- a/drivers/iio/adc/stm32-adc-core.c > +++ b/drivers/iio/adc/stm32-adc-core.c > @@ -79,6 +79,7 @@ struct stm32_adc_priv_cfg { > * @domain: irq domain reference > * @aclk: clock reference for the analog circuitry > * @bclk: bus clock common for all ADCs, depends on part used > + * @max_clk_rate: desired maximum clock rate > * @booster: booster supply reference > * @vdd: vdd supply reference > * @vdda: vdda analog supply reference > @@ -95,6 +96,7 @@ struct stm32_adc_priv { > struct irq_domain *domain; > struct clk *aclk; > struct clk *bclk; > + u32 max_clk_rate; > struct regulator *booster; > struct regulator *vdd; > struct regulator *vdda; > @@ -141,7 +143,7 @@ static int stm32f4_adc_clk_sel(struct platform_device *pdev, > } > > for (i = 0; i < ARRAY_SIZE(stm32f4_pclk_div); i++) { > - if ((rate / stm32f4_pclk_div[i]) <= priv->cfg->max_clk_rate_hz) > + if ((rate / stm32f4_pclk_div[i]) <= priv->max_clk_rate) > break; > } > if (i >= ARRAY_SIZE(stm32f4_pclk_div)) { > @@ -230,7 +232,7 @@ static int stm32h7_adc_clk_sel(struct platform_device *pdev, > if (ckmode) > continue; > > - if ((rate / div) <= priv->cfg->max_clk_rate_hz) > + if ((rate / div) <= priv->max_clk_rate) > goto out; > } > } > @@ -250,7 +252,7 @@ static int stm32h7_adc_clk_sel(struct platform_device *pdev, > if (!ckmode) > continue; > > - if ((rate / div) <= priv->cfg->max_clk_rate_hz) > + if ((rate / div) <= priv->max_clk_rate) > goto out; > } > > @@ -655,6 +657,7 @@ static int stm32_adc_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *np = pdev->dev.of_node; > struct resource *res; > + u32 max_rate; > int ret; > > if (!pdev->dev.of_node) > @@ -731,6 +734,13 @@ static int stm32_adc_probe(struct platform_device *pdev) > priv->common.vref_mv = ret / 1000; > dev_dbg(&pdev->dev, "vref+=%dmV\n", priv->common.vref_mv); > > + ret = of_property_read_u32(pdev->dev.of_node, "st,max-clk-rate-hz", > + &max_rate); > + if (!ret) > + priv->max_clk_rate = min(max_rate, priv->cfg->max_clk_rate_hz); > + else > + priv->max_clk_rate = priv->cfg->max_clk_rate_hz; > + > ret = priv->cfg->clk_sel(pdev, priv); > if (ret < 0) > goto err_hw_stop; ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: adc: stm32: allow to tune analog clock 2019-11-03 12:30 ` Jonathan Cameron @ 2019-11-09 12:38 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2019-11-09 12:38 UTC (permalink / raw) To: Fabrice Gasnier Cc: robh+dt, alexandre.torgue, mark.rutland, mcoquelin.stm32, lars, knaack.h, pmeerw, linux-iio, devicetree, linux-stm32, linux-arm-kernel, linux-kernel On Sun, 3 Nov 2019 12:30:42 +0000 Jonathan Cameron <jic23@kernel.org> wrote: > On Mon, 28 Oct 2019 17:11:48 +0100 > Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > > > Add new optional dt property to tune analog clock prescaler. > > Driver looks for optional "st,max-clk-rate-hz", then computes > > best approximation below that rate, using ADC internal prescaler. > > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > If the previous email I wrote on this got to anyone before I hit > cancel, please ignore. Had completely failed to read the code correctly. > > Anyhow this seems fine to me, but given there are a lot of existing > clk related bindings I'd like to give a little longer for Rob to > have a chance to take a look at the binding. > > Give me a poke if I seem to have lost this in a week or so. Applied to the togreg branch of iio.git. Shortly to be pushed out as testing for the autobuilders to poke at it. Thanks, Jonathan > > Thanks, > > Jonathan > > > > > --- > > drivers/iio/adc/stm32-adc-core.c | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c > > index 20c626c..6537f4f 100644 > > --- a/drivers/iio/adc/stm32-adc-core.c > > +++ b/drivers/iio/adc/stm32-adc-core.c > > @@ -79,6 +79,7 @@ struct stm32_adc_priv_cfg { > > * @domain: irq domain reference > > * @aclk: clock reference for the analog circuitry > > * @bclk: bus clock common for all ADCs, depends on part used > > + * @max_clk_rate: desired maximum clock rate > > * @booster: booster supply reference > > * @vdd: vdd supply reference > > * @vdda: vdda analog supply reference > > @@ -95,6 +96,7 @@ struct stm32_adc_priv { > > struct irq_domain *domain; > > struct clk *aclk; > > struct clk *bclk; > > + u32 max_clk_rate; > > struct regulator *booster; > > struct regulator *vdd; > > struct regulator *vdda; > > @@ -141,7 +143,7 @@ static int stm32f4_adc_clk_sel(struct platform_device *pdev, > > } > > > > for (i = 0; i < ARRAY_SIZE(stm32f4_pclk_div); i++) { > > - if ((rate / stm32f4_pclk_div[i]) <= priv->cfg->max_clk_rate_hz) > > + if ((rate / stm32f4_pclk_div[i]) <= priv->max_clk_rate) > > break; > > } > > if (i >= ARRAY_SIZE(stm32f4_pclk_div)) { > > @@ -230,7 +232,7 @@ static int stm32h7_adc_clk_sel(struct platform_device *pdev, > > if (ckmode) > > continue; > > > > - if ((rate / div) <= priv->cfg->max_clk_rate_hz) > > + if ((rate / div) <= priv->max_clk_rate) > > goto out; > > } > > } > > @@ -250,7 +252,7 @@ static int stm32h7_adc_clk_sel(struct platform_device *pdev, > > if (!ckmode) > > continue; > > > > - if ((rate / div) <= priv->cfg->max_clk_rate_hz) > > + if ((rate / div) <= priv->max_clk_rate) > > goto out; > > } > > > > @@ -655,6 +657,7 @@ static int stm32_adc_probe(struct platform_device *pdev) > > struct device *dev = &pdev->dev; > > struct device_node *np = pdev->dev.of_node; > > struct resource *res; > > + u32 max_rate; > > int ret; > > > > if (!pdev->dev.of_node) > > @@ -731,6 +734,13 @@ static int stm32_adc_probe(struct platform_device *pdev) > > priv->common.vref_mv = ret / 1000; > > dev_dbg(&pdev->dev, "vref+=%dmV\n", priv->common.vref_mv); > > > > + ret = of_property_read_u32(pdev->dev.of_node, "st,max-clk-rate-hz", > > + &max_rate); > > + if (!ret) > > + priv->max_clk_rate = min(max_rate, priv->cfg->max_clk_rate_hz); > > + else > > + priv->max_clk_rate = priv->cfg->max_clk_rate_hz; > > + > > ret = priv->cfg->clk_sel(pdev, priv); > > if (ret < 0) > > goto err_hw_stop; > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-09 12:38 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-28 16:11 [PATCH 0/2] iio: adc: stm32: add max clock rate Fabrice Gasnier 2019-10-28 16:11 ` [PATCH 1/2] dt-bindings: iio: stm32-adc: add max clock rate property Fabrice Gasnier 2019-11-06 3:29 ` Rob Herring 2019-11-09 12:36 ` Jonathan Cameron 2019-10-28 16:11 ` [PATCH 2/2] iio: adc: stm32: allow to tune analog clock Fabrice Gasnier 2019-11-03 12:30 ` Jonathan Cameron 2019-11-09 12:38 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).