From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE7AC17443 for ; Sun, 10 Nov 2019 11:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28E78214E0 for ; Sun, 10 Nov 2019 11:37:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="m398mtAE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbfKJLhX (ORCPT ); Sun, 10 Nov 2019 06:37:23 -0500 Received: from mail.skyhub.de ([5.9.137.197]:56682 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726684AbfKJLhW (ORCPT ); Sun, 10 Nov 2019 06:37:22 -0500 Received: from zn.tnic (p200300EC2F26BB00DC95C53DC58BD1F9.dip0.t-ipconnect.de [IPv6:2003:ec:2f26:bb00:dc95:c53d:c58b:d1f9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 813B81EC095C; Sun, 10 Nov 2019 12:37:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1573385836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q8TAlmP8ZTd6fsyEb4l2OyXP0kwpjVffA/Tm1c3pVpU=; b=m398mtAEp0tj6XvjqLKKkTzJeQbFbvELvW+eztEthlDbWg1egvCL85MpLbIQs/cvyoGx/v 2T7I9mpj8WjNyT5cV8nk1SEdryDkl7SUkfVotdxFbuUFC+UFZravZUUwhwJ4+eOuylaOI6 S1+PVuhWtneDpi7o4R8A1boamU8ak9g= Date: Sun, 10 Nov 2019 12:37:12 +0100 From: Borislav Petkov To: Robert Richter Cc: Mauro Carvalho Chehab , Tony Luck , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mauro Carvalho Chehab Subject: Re: [PATCH v2 03/20] EDAC: Introduce mci_for_each_dimm() iterator Message-ID: <20191110113712.GA12627@zn.tnic> References: <20191106093239.25517-1-rrichter@marvell.com> <20191106093239.25517-4-rrichter@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191106093239.25517-4-rrichter@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 09:33:07AM +0000, Robert Richter wrote: > @@ -702,6 +705,7 @@ EXPORT_SYMBOL_GPL(edac_get_owner); > int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci, > const struct attribute_group **groups) > { > + struct dimm_info *dimm; > int ret = -EINVAL; > edac_dbg(0, "\n"); > drivers/edac/edac_mc.c: In function ‘edac_mc_add_mc_with_groups’: drivers/edac/edac_mc.c:711:20: warning: unused variable ‘dimm’ [-Wunused-variable] struct dimm_info *dimm; ^~~~ Pushing the declaration into the #ifdef CONFIG_EDAC_DEBUG block. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette