From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4059C17443 for ; Sun, 10 Nov 2019 14:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5EB520818 for ; Sun, 10 Nov 2019 14:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573397609; bh=/iU5aWjqTkORuN4+DNIlfl6ksnB2MbsPSLVgGE6Ogs8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=A3aC3gQzjamXbxNKfD5kkG6D/pdZlNghAyrGk20DMUoZ/KB27u20Cjb2Cm9VnY/pb 2yjbHhGysWZ2KzDBmN9qDq/DXpGKT4NvQu9dQThGHYgbUiPqiBOgv+yrldgdABeu/X rGxp5gsd1VpjGzYyuvoX9IzaOi3NicAGjOWZZWIs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbfKJOx2 (ORCPT ); Sun, 10 Nov 2019 09:53:28 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:58757 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726402AbfKJOx2 (ORCPT ); Sun, 10 Nov 2019 09:53:28 -0500 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iToaY-0002r6-32; Sun, 10 Nov 2019 15:53:14 +0100 Date: Sun, 10 Nov 2019 14:53:12 +0000 From: Marc Zyngier To: Eddie James Cc: linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, joel@jms.id.au, jason@lakedaemon.net, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org Subject: Re: [PATCH 02/12] irqchip: Add Aspeed SCU interrupt controller Message-ID: <20191110145312.3805b25b@why> In-Reply-To: <1573244313-9190-3-git-send-email-eajames@linux.ibm.com> References: <1573244313-9190-1-git-send-email-eajames@linux.ibm.com> <1573244313-9190-3-git-send-email-eajames@linux.ibm.com> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: eajames@linux.ibm.com, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, joel@jms.id.au, jason@lakedaemon.net, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Nov 2019 14:18:23 -0600 Eddie James wrote: Hi Eddie, > The Aspeed SOCs provide some interrupts through the System Control > Unit registers. Add an interrupt controller that provides these > interrupts to the system. > > Signed-off-by: Eddie James > --- > MAINTAINERS | 1 + > drivers/irqchip/Makefile | 2 +- > drivers/irqchip/irq-aspeed-scu-ic.c | 233 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 235 insertions(+), 1 deletion(-) > create mode 100644 drivers/irqchip/irq-aspeed-scu-ic.c [...] > +static int aspeed_scu_ic_map(struct irq_domain *domain, unsigned int irq, > + irq_hw_number_t hwirq) > +{ > + irq_set_chip_and_handler(irq, &aspeed_scu_ic_chip, handle_simple_irq); handle_simple_irq is usually wrong, and works badly with threaded interrupts. I suggest you'd change it to handle_level_irq, which probably matches the behaviour of the controller. Otherwise, this looks good. Thanks, M. -- Jazz is not dead. It just smells funny...