From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: robh+dt@kernel.org, nm@ti.com, ssantosh@kernel.org,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, grygorii.strashko@ti.com,
lokeshvutla@ti.com, t-kristo@ti.com, tony@atomide.com,
j-keerthy@ti.com
Subject: Re: [PATCH v4 10/15] dmaengine: ti: New driver for K3 UDMA - split#2: probe/remove, xlate and filter_fn
Date: Mon, 11 Nov 2019 11:03:01 +0530 [thread overview]
Message-ID: <20191111053301.GO952516@vkoul-mobl> (raw)
In-Reply-To: <20191101084135.14811-11-peter.ujfalusi@ti.com>
On 01-11-19, 10:41, Peter Ujfalusi wrote:
> +static bool udma_dma_filter_fn(struct dma_chan *chan, void *param)
> +{
> + struct psil_endpoint_config *ep_config;
> + struct udma_chan *uc;
> + struct udma_dev *ud;
> + u32 *args;
> +
> + if (chan->device->dev->driver != &udma_driver.driver)
> + return false;
> +
> + uc = to_udma_chan(chan);
> + ud = uc->ud;
> + args = param;
> + uc->remote_thread_id = args[0];
> +
> + if (uc->remote_thread_id & K3_PSIL_DST_THREAD_ID_OFFSET)
> + uc->dir = DMA_MEM_TO_DEV;
> + else
> + uc->dir = DMA_DEV_TO_MEM;
Can you explain this a bit?
> +static int udma_remove(struct platform_device *pdev)
> +{
> + struct udma_dev *ud = platform_get_drvdata(pdev);
> +
> + of_dma_controller_free(pdev->dev.of_node);
> + dma_async_device_unregister(&ud->ddev);
> +
> + /* Make sure that we did proper cleanup */
> + cancel_work_sync(&ud->purge_work);
> + udma_purge_desc_work(&ud->purge_work);
kill the vchan tasklets at it too please
--
~Vinod
next prev parent reply other threads:[~2019-11-11 5:33 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 8:41 [PATCH v4 00/15] dmaengine/soc: Add Texas Instruments UDMA support Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 01/15] bindings: soc: ti: add documentation for k3 ringacc Peter Ujfalusi
2019-11-11 4:07 ` Vinod Koul
2019-11-11 7:24 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 02/15] soc: ti: k3: add navss ringacc driver Peter Ujfalusi
2019-11-11 4:21 ` Vinod Koul
2019-11-11 7:39 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 03/15] dmaengine: doc: Add sections for per descriptor metadata support Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 04/15] dmaengine: Add metadata_ops for dma_async_tx_descriptor Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 05/15] dmaengine: Add support for reporting DMA cached data amount Peter Ujfalusi
2019-11-11 4:39 ` Vinod Koul
2019-11-11 8:00 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 06/15] dmaengine: ti: Add cppi5 header for K3 NAVSS/UDMA Peter Ujfalusi
2019-11-05 7:40 ` Tero Kristo
2019-11-01 8:41 ` [PATCH v4 07/15] dmaengine: ti: k3 PSI-L remote endpoint configuration Peter Ujfalusi
2019-11-05 7:49 ` Tero Kristo
2019-11-05 8:13 ` Peter Ujfalusi
2019-11-05 10:00 ` Grygorii Strashko
2019-11-05 10:27 ` Peter Ujfalusi
2019-11-05 11:25 ` Grygorii Strashko
2019-11-11 4:47 ` Vinod Koul
2019-11-11 8:47 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 08/15] dt-bindings: dma: ti: Add document for K3 UDMA Peter Ujfalusi
2019-11-05 2:19 ` Rob Herring
2019-11-05 10:08 ` Peter Ujfalusi
2019-11-14 17:53 ` Rob Herring
2019-11-15 9:45 ` Peter Ujfalusi
2019-11-26 8:29 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 09/15] dmaengine: ti: New driver for K3 UDMA - split#1: defines, structs, io func Peter Ujfalusi
2019-11-11 5:28 ` Vinod Koul
2019-11-11 8:33 ` Peter Ujfalusi
2019-11-11 9:00 ` Vinod Koul
2019-11-11 9:12 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 10/15] dmaengine: ti: New driver for K3 UDMA - split#2: probe/remove, xlate and filter_fn Peter Ujfalusi
2019-11-11 5:33 ` Vinod Koul [this message]
2019-11-11 9:16 ` Peter Ujfalusi
2019-11-12 5:34 ` Vinod Koul
2019-11-12 7:22 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 11/15] dmaengine: ti: New driver for K3 UDMA - split#3: alloc/free chan_resources Peter Ujfalusi
2019-11-11 6:06 ` Vinod Koul
2019-11-11 9:40 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 12/15] dmaengine: ti: New driver for K3 UDMA - split#4: dma_device callbacks 1 Peter Ujfalusi
2019-11-11 6:09 ` Vinod Koul
2019-11-11 10:29 ` Peter Ujfalusi
2019-11-12 5:36 ` Vinod Koul
2019-11-12 7:24 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 13/15] dmaengine: ti: New driver for K3 UDMA - split#5: dma_device callbacks 2 Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 14/15] dmaengine: ti: New driver for K3 UDMA - split#6: Kconfig and Makefile Peter Ujfalusi
2019-11-11 6:11 ` Vinod Koul
2019-11-11 10:30 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 15/15] dmaengine: ti: k3-udma: Add glue layer for non DMAengine users Peter Ujfalusi
2019-11-11 6:12 ` Vinod Koul
2019-11-11 10:31 ` Peter Ujfalusi
2019-11-12 5:37 ` Vinod Koul
2019-11-12 7:25 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111053301.GO952516@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).