archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <>
To: Tony Lu <>
Subject: Re: [PATCH] net: remove static inline from dev_put/dev_hold
Date: Mon, 11 Nov 2019 08:56:32 -0800	[thread overview]
Message-ID: <20191111085632.24d88706@hermes.lan> (raw)
In-Reply-To: <>

On Mon, 11 Nov 2019 22:05:03 +0800
Tony Lu <> wrote:

> This patch removes static inline from dev_put/dev_hold in order to help
> trace the pcpu_refcnt leak of net_device.
> We have sufferred this kind of issue for several times during
> manipulating NIC between different net namespaces. It prints this
> log in dmesg:
>   unregister_netdevice: waiting for eth0 to become free. Usage count = 1
> However, it is hard to find out who called and leaked refcnt in time. It
> only left the crime scene but few evidence. Once leaked, it is not
> safe to fix it up on the running host. We can't trace dev_put/dev_hold
> directly, for the functions are inlined and used wildly amoung modules.
> And this issue is common, there are tens of patches fix net_device
> refcnt leak for various causes.
> To trace the refcnt manipulating, this patch removes static inline from
> dev_put/dev_hold. We can use handy tools, such as eBPF with kprobe, to
> find out who holds but forgets to put refcnt. This will not be called
> frequently, so the overhead is limited.
> Signed-off-by: Tony Lu <>

In the past dev_hold/dev_put was in the hot path for several
operations. What is the performance implication of doing this?

  reply	other threads:[~2019-11-11 16:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 14:05 [PATCH] net: remove static inline from dev_put/dev_hold Tony Lu
2019-11-11 16:56 ` Stephen Hemminger [this message]
2019-11-12  7:18   ` Tony Lu
2019-11-11 17:21 ` Eric Dumazet
2019-11-12  9:48   ` Tony Lu
2019-11-11 21:26 ` Cong Wang
2019-11-12  8:47   ` Tony Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111085632.24d88706@hermes.lan \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).