* [PATCH -next] clk: armada-xp: remove unused code
@ 2019-11-11 14:04 YueHaibing
2019-11-13 21:40 ` Stephen Boyd
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-11-11 14:04 UTC (permalink / raw)
To: mturquette, sboyd, yuehaibing, gregory.clement, tiny.windzz
Cc: linux-clk, linux-kernel
drivers/clk/mvebu/armada-xp.c:171:38: warning:
mv98dx3236_coreclks defined but not used [-Wunused-const-variable=]
drivers/clk/mvebu/armada-xp.c:213:41: warning:
mv98dx3236_gating_desc defined but not used [-Wunused-const-variable=]
They are not used since commit 337072604224 ("clk: mvebu:
Expand mv98dx3236-core-clock support").
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/clk/mvebu/armada-xp.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
index fa15682..4566565 100644
--- a/drivers/clk/mvebu/armada-xp.c
+++ b/drivers/clk/mvebu/armada-xp.c
@@ -50,12 +50,6 @@ static u32 __init axp_get_tclk_freq(void __iomem *sar)
return 250000000;
}
-/* MV98DX3236 TCLK frequency is fixed to 200MHz */
-static u32 __init mv98dx3236_get_tclk_freq(void __iomem *sar)
-{
- return 200000000;
-}
-
static const u32 axp_cpu_freqs[] __initconst = {
1000000000,
1066000000,
@@ -93,12 +87,6 @@ static u32 __init axp_get_cpu_freq(void __iomem *sar)
return cpu_freq;
}
-/* MV98DX3236 CLK frequency is fixed to 800MHz */
-static u32 __init mv98dx3236_get_cpu_freq(void __iomem *sar)
-{
- return 800000000;
-}
-
static const int axp_nbclk_ratios[32][2] __initconst = {
{0, 1}, {1, 2}, {2, 2}, {2, 2},
{1, 2}, {1, 2}, {1, 1}, {2, 3},
@@ -168,11 +156,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
.num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
};
-static const struct coreclk_soc_desc mv98dx3236_coreclks = {
- .get_tclk_freq = mv98dx3236_get_tclk_freq,
- .get_cpu_freq = mv98dx3236_get_cpu_freq,
-};
-
/*
* Clock Gating Control
*/
@@ -210,15 +193,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
{ }
};
-static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
- { "ge1", NULL, 3, 0 },
- { "ge0", NULL, 4, 0 },
- { "pex00", NULL, 5, 0 },
- { "sdio", NULL, 17, 0 },
- { "xor0", NULL, 22, 0 },
- { }
-};
-
static void __init axp_clk_init(struct device_node *np)
{
struct device_node *cgnp =
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] clk: armada-xp: remove unused code
2019-11-11 14:04 [PATCH -next] clk: armada-xp: remove unused code YueHaibing
@ 2019-11-13 21:40 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-11-13 21:40 UTC (permalink / raw)
To: gregory.clement, mturquette, tiny.windzz, yuehaibing
Cc: linux-clk, linux-kernel
Quoting YueHaibing (2019-11-11 06:04:20)
> drivers/clk/mvebu/armada-xp.c:171:38: warning:
> mv98dx3236_coreclks defined but not used [-Wunused-const-variable=]
> drivers/clk/mvebu/armada-xp.c:213:41: warning:
> mv98dx3236_gating_desc defined but not used [-Wunused-const-variable=]
>
> They are not used since commit 337072604224 ("clk: mvebu:
> Expand mv98dx3236-core-clock support").
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] clk: armada-xp: remove unused code
2019-08-16 14:02 YueHaibing
@ 2019-08-16 17:34 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-08-16 17:34 UTC (permalink / raw)
To: YueHaibing, gregory.clement, mturquette
Cc: linux-kernel, linux-clk, YueHaibing
Quoting YueHaibing (2019-08-16 07:02:00)
> drivers/clk/mvebu/armada-xp.c:171:38: warning:
> mv98dx3236_coreclks defined but not used [-Wunused-const-variable=]
> drivers/clk/mvebu/armada-xp.c:213:41: warning:
> mv98dx3236_gating_desc defined but not used [-Wunused-const-variable=]
>
> They are never used, so can be remove. Also remove
> the related functions.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
I'll wait for Gregory to review.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] clk: armada-xp: remove unused code
@ 2019-08-16 14:02 YueHaibing
2019-08-16 17:34 ` Stephen Boyd
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-08-16 14:02 UTC (permalink / raw)
To: mturquette, sboyd, gregory.clement; +Cc: linux-kernel, linux-clk, YueHaibing
drivers/clk/mvebu/armada-xp.c:171:38: warning:
mv98dx3236_coreclks defined but not used [-Wunused-const-variable=]
drivers/clk/mvebu/armada-xp.c:213:41: warning:
mv98dx3236_gating_desc defined but not used [-Wunused-const-variable=]
They are never used, so can be remove. Also remove
the related functions.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/clk/mvebu/armada-xp.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
index fa15682..4566565 100644
--- a/drivers/clk/mvebu/armada-xp.c
+++ b/drivers/clk/mvebu/armada-xp.c
@@ -50,12 +50,6 @@ static u32 __init axp_get_tclk_freq(void __iomem *sar)
return 250000000;
}
-/* MV98DX3236 TCLK frequency is fixed to 200MHz */
-static u32 __init mv98dx3236_get_tclk_freq(void __iomem *sar)
-{
- return 200000000;
-}
-
static const u32 axp_cpu_freqs[] __initconst = {
1000000000,
1066000000,
@@ -93,12 +87,6 @@ static u32 __init axp_get_cpu_freq(void __iomem *sar)
return cpu_freq;
}
-/* MV98DX3236 CLK frequency is fixed to 800MHz */
-static u32 __init mv98dx3236_get_cpu_freq(void __iomem *sar)
-{
- return 800000000;
-}
-
static const int axp_nbclk_ratios[32][2] __initconst = {
{0, 1}, {1, 2}, {2, 2}, {2, 2},
{1, 2}, {1, 2}, {1, 1}, {2, 3},
@@ -168,11 +156,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
.num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
};
-static const struct coreclk_soc_desc mv98dx3236_coreclks = {
- .get_tclk_freq = mv98dx3236_get_tclk_freq,
- .get_cpu_freq = mv98dx3236_get_cpu_freq,
-};
-
/*
* Clock Gating Control
*/
@@ -210,15 +193,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
{ }
};
-static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
- { "ge1", NULL, 3, 0 },
- { "ge0", NULL, 4, 0 },
- { "pex00", NULL, 5, 0 },
- { "sdio", NULL, 17, 0 },
- { "xor0", NULL, 22, 0 },
- { }
-};
-
static void __init axp_clk_init(struct device_node *np)
{
struct device_node *cgnp =
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-13 21:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 14:04 [PATCH -next] clk: armada-xp: remove unused code YueHaibing
2019-11-13 21:40 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 14:02 YueHaibing
2019-08-16 17:34 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).