From: Andrew Morton <akpm@linux-foundation.org>
To: ira.weiny@intel.com
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-nfs@vger.kernel.org, linux-mm@kvack.org,
Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 2/2] fs: Move swap_[de]activate to file_operations
Date: Mon, 11 Nov 2019 16:43:20 -0800 [thread overview]
Message-ID: <20191111164320.80f814161469055b14f27045@linux-foundation.org> (raw)
In-Reply-To: <20191112003452.4756-3-ira.weiny@intel.com>
On Mon, 11 Nov 2019 16:34:52 -0800 ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> swap_activate() and swap_deactivate() have nothing to do with
> address spaces. We want to eventually make the address space operations
> dynamic to switch inode flags on the fly.
What does this mean?
> So to simplify this code as
> well as properly track these operations we move these functions to the
> file_operations vector.
>
> This has been tested with XFS but not NFS, f2fs, or btrfs.
>
> Also note f2fs and xfs have simple moves of their functions to
> facilitate compilation. No functional changes are contained within
> those functions.
>
> ...
>
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -11002,6 +11002,8 @@ static const struct file_operations btrfs_dir_file_operations = {
> #endif
> .release = btrfs_release_file,
> .fsync = btrfs_sync_file,
> + .swap_activate = btrfs_swap_activate,
> + .swap_deactivate = btrfs_swap_deactivate,
> };
Shouldn't this be btrfs_file_operations?
next prev parent reply other threads:[~2019-11-12 0:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:34 [PATCH 0/2] Move swap functions out of address space operations ira.weiny
2019-11-12 0:34 ` [PATCH 1/2] fs: Clean up mapping variable ira.weiny
2019-11-12 1:20 ` Darrick J. Wong
2019-11-12 0:34 ` [PATCH 2/2] fs: Move swap_[de]activate to file_operations ira.weiny
2019-11-12 0:43 ` Andrew Morton [this message]
2019-11-12 12:00 ` Nikolay Borisov
2019-11-12 13:33 ` Jan Kara
2019-11-12 17:05 ` Weiny, Ira
2019-11-12 1:20 ` Darrick J. Wong
2019-11-12 23:52 ` Ira Weiny
2019-11-12 6:55 ` Christoph Hellwig
2019-11-12 13:30 ` Jan Kara
2019-11-12 17:09 ` Weiny, Ira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111164320.80f814161469055b14f27045@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).