From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B615AC43331 for ; Mon, 11 Nov 2019 18:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86BEA222C1 for ; Mon, 11 Nov 2019 18:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497621; bh=H6V87+rGGbmXBhNnZctbvfyuGfxIShbUzx2vWyqDkqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FY2f0tfmekGI4jjoxhzeAvFnS7+jpSJMOWnf1VLa6kSaqBE/6nNmy3y0hQxcQM3mQ QGqtXH8zptpBIxXcB67gDzBfq+aL+KCyitA1QKQIQ3sItI5NfJbeGY7JkPXR9Qg79H X08dFWHH4To/to/QkYCeQPsV9QRHvVJlA9oVk7hk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729242AbfKKSkU (ORCPT ); Mon, 11 Nov 2019 13:40:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:59444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728388AbfKKSkS (ORCPT ); Mon, 11 Nov 2019 13:40:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD245214E0; Mon, 11 Nov 2019 18:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497617; bh=H6V87+rGGbmXBhNnZctbvfyuGfxIShbUzx2vWyqDkqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e7SSlCTq40kS+YcgTr5pR+SGgSS54219zOdNBvQITS0OlIAi8XIYylRNdgXeQZSuo NOtn6tAx2HuNThMsd1Q6XF/rZ5OYa3amE72/3KoLDJra9wngE/ds/T5BXzCfFV1shr 66aA2GVJTCwvnfbct4DT9KObq8awOxqdgMz52wCs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikhil Badola , Ran Wang , Peter Chen , Felipe Balbi , Sasha Levin Subject: [PATCH 4.14 082/105] usb: fsl: Check memory resource before releasing it Date: Mon, 11 Nov 2019 19:28:52 +0100 Message-Id: <20191111181447.033495169@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181421.390326245@linuxfoundation.org> References: <20191111181421.390326245@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nikhil Badola [ Upstream commit bc1e3a2dd0c9954fd956ac43ca2876bbea018c01 ] Check memory resource existence before releasing it to avoid NULL pointer dereference Signed-off-by: Nikhil Badola Reviewed-by: Ran Wang Reviewed-by: Peter Chen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c index 7874c112f3fd8..ee48c7938d619 100644 --- a/drivers/usb/gadget/udc/fsl_udc_core.c +++ b/drivers/usb/gadget/udc/fsl_udc_core.c @@ -2569,7 +2569,7 @@ static int fsl_udc_remove(struct platform_device *pdev) dma_pool_destroy(udc_controller->td_pool); free_irq(udc_controller->irq, udc_controller); iounmap(dr_regs); - if (pdata->operating_mode == FSL_USB2_DR_DEVICE) + if (res && (pdata->operating_mode == FSL_USB2_DR_DEVICE)) release_mem_region(res->start, resource_size(res)); /* free udc --wait for the release() finished */ -- 2.20.1