From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DB5C17445 for ; Mon, 11 Nov 2019 18:39:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09BE62196E for ; Mon, 11 Nov 2019 18:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497548; bh=EUqYUynVvxUCW80m8A1QyQAuyVCbPM3PYh9k7+enP3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pglthbzeNsFs83jeKb0C2NmUaAn28I1Y9h/YemO+8yUINZgpsh9dHTQEnYcFM3c8y gh8YbaJ5GNO61uoRwsRU/RvLOjpisSefDB6kt4HbgOTArhAJblMmnvzUnCV9QrASzb G8kdedxARPUS0rVPySy2dSOrdGF5BXvL7ZhzSuC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729128AbfKKSjG (ORCPT ); Mon, 11 Nov 2019 13:39:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:58064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728565AbfKKSjC (ORCPT ); Mon, 11 Nov 2019 13:39:02 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B2D3222BD; Mon, 11 Nov 2019 18:39:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497541; bh=EUqYUynVvxUCW80m8A1QyQAuyVCbPM3PYh9k7+enP3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nDAJ55MnSNg+UZrtNroYk4YnZbocAklmfP0AFlPt5xbASo1qRWzT6E4CMrWEsx5mM fzf4mDOmVTf1HHNFk8q3EriME3unv/a+vPaSbqW/5NUHekbVAJ0Tx+8k6HSU9EofN2 Nxi0cUb0vmYaZQng6biAKciK7eQ3/lHsWm+vwOSY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cristian Birsan , Felipe Balbi , Sasha Levin Subject: [PATCH 4.14 083/105] usb: gadget: udc: atmel: Fix interrupt storm in FIFO mode. Date: Mon, 11 Nov 2019 19:28:53 +0100 Message-Id: <20191111181447.129059299@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181421.390326245@linuxfoundation.org> References: <20191111181421.390326245@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cristian Birsan [ Upstream commit ba3a1a915c49cc3023e4ddfc88f21e7514e82aa4 ] Fix interrupt storm generated by endpoints when working in FIFO mode. The TX_COMPLETE interrupt is used only by control endpoints processing. Do not enable it for other types of endpoints. Fixes: 914a3f3b3754 ("USB: add atmel_usba_udc driver") Signed-off-by: Cristian Birsan Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index cb66f982c313b..39676824a2c6f 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -488,9 +488,11 @@ static void submit_request(struct usba_ep *ep, struct usba_request *req) next_fifo_transaction(ep, req); if (req->last_transaction) { usba_ep_writel(ep, CTL_DIS, USBA_TX_PK_RDY); - usba_ep_writel(ep, CTL_ENB, USBA_TX_COMPLETE); + if (ep_is_control(ep)) + usba_ep_writel(ep, CTL_ENB, USBA_TX_COMPLETE); } else { - usba_ep_writel(ep, CTL_DIS, USBA_TX_COMPLETE); + if (ep_is_control(ep)) + usba_ep_writel(ep, CTL_DIS, USBA_TX_COMPLETE); usba_ep_writel(ep, CTL_ENB, USBA_TX_PK_RDY); } } -- 2.20.1