From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com,
rkrcmar@redhat.com, rafael.j.wysocki@intel.com,
joao.m.martins@oracle.com, mtosatti@redhat.com,
kvm@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH RESEND v2 2/4] KVM: ensure grow start value is nonzero
Date: Mon, 11 Nov 2019 12:13:20 -0800 [thread overview]
Message-ID: <20191111201320.GA7431@linux.intel.com> (raw)
In-Reply-To: <1573041302-4904-3-git-send-email-zhenzhong.duan@oracle.com>
On Wed, Nov 06, 2019 at 07:55:00PM +0800, Zhenzhong Duan wrote:
> vcpu->halt_poll_ns could be zeroed in certain cases (e.g. by
> halt_poll_ns = 0). If halt_poll_grow_start is zero,
> vcpu->halt_poll_ns will never be bigger than zero.
>
> Use param callback to avoid writing zero to halt_poll_grow_start.
This doesn't explain why allowing an admin to disable halt polling by
writing halt_poll_grow_start=0 is a bad thing. Paolo had the same
question in v1, here[1] and in the guest driver[2].
[1] https://lkml.kernel.org/r/57679389-6e4a-b7ad-559f-3128a608c28a@redhat.com
[2] https://lkml.kernel.org/r/391dd11b-ebbb-28ff-5e57-4a795cd16a1b@redhat.com
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> ---
> virt/kvm/kvm_main.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d6f0696..359516b 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -69,6 +69,26 @@
> MODULE_AUTHOR("Qumranet");
> MODULE_LICENSE("GPL");
>
> +static int grow_start_set(const char *val, const struct kernel_param *kp)
> +{
> + int ret;
> + unsigned int n;
> +
> + if (!val)
> + return -EINVAL;
> +
> + ret = kstrtouint(val, 0, &n);
> + if (ret || !n)
> + return -EINVAL;
> +
> + return param_set_uint(val, kp);
> +}
> +
> +static const struct kernel_param_ops grow_start_ops = {
> + .set = grow_start_set,
> + .get = param_get_uint,
> +};
> +
> /* Architectures should define their poll value according to the halt latency */
> unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
> module_param(halt_poll_ns, uint, 0644);
> @@ -81,7 +101,7 @@
>
> /* The start value to grow halt_poll_ns from */
> unsigned int halt_poll_ns_grow_start = 10000; /* 10us */
> -module_param(halt_poll_ns_grow_start, uint, 0644);
> +module_param_cb(halt_poll_ns_grow_start, &grow_start_ops, &halt_poll_ns_grow_start, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns_grow_start);
>
> /* Default resets per-vcpu halt_poll_ns . */
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2019-11-11 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 11:54 [PATCH RESEND v2 0/4] misc fixes on halt-poll code for both KVM and guest Zhenzhong Duan
2019-11-06 11:54 ` [PATCH RESEND v2 1/4] cpuidle-haltpoll: ensure grow start value is nonzero Zhenzhong Duan
2019-11-15 10:06 ` Rafael J. Wysocki
2019-11-15 10:16 ` Rafael J. Wysocki
2019-11-15 10:26 ` Rafael J. Wysocki
2019-11-17 9:02 ` Zhenzhong Duan
2019-11-06 11:55 ` [PATCH RESEND v2 2/4] KVM: " Zhenzhong Duan
2019-11-11 20:13 ` Sean Christopherson [this message]
2019-11-12 12:19 ` Zhenzhong Duan
2019-11-06 11:55 ` [PATCH RESEND v2 3/4] cpuidle-haltpoll: ensure cpu_halt_poll_us in right scope Zhenzhong Duan
2019-11-15 10:45 ` Rafael J. Wysocki
2019-11-17 8:57 ` Zhenzhong Duan
2019-11-06 11:55 ` [PATCH RESEND v2 4/4] KVM: ensure vCPU halt_poll_us " Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111201320.GA7431@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rkrcmar@redhat.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).