From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
s-anna@ti.com
Subject: Re: [PATCH 13/17] remoteproc/omap: add support for system suspend/resume
Date: Mon, 11 Nov 2019 22:15:36 -0800 [thread overview]
Message-ID: <20191112061536.GO3108315@builder> (raw)
In-Reply-To: <20191028124238.19224-14-t-kristo@ti.com>
On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote:
> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
[..]
> +static int _omap_rproc_suspend(struct rproc *rproc)
I think it would make sense to inline this and _omap_rproc_resume() in
their single call sites.
[..]
> +static int _omap_rproc_resume(struct rproc *rproc)
> +{
[..]
> @@ -806,6 +972,14 @@ static int omap_rproc_probe(struct platform_device *pdev)
> oproc->num_timers);
> }
>
> + init_completion(&oproc->pm_comp);
> +
> + oproc->fck = of_clk_get(np, 0);
devm_clk_get() ?
Otherwise I think you're lacking a clk_put() in omap_rproc_remove()
Regards,
Bjorn
next prev parent reply other threads:[~2019-11-12 6:15 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 12:42 [PATCH 00/17] remoteproc: omap changes on top of v5.4-rc1 Tero Kristo
2019-10-28 12:42 ` [PATCH 01/17] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo
2019-11-06 3:27 ` Rob Herring
2019-11-06 12:44 ` Tero Kristo
2019-11-06 13:27 ` Rob Herring
2019-11-06 13:50 ` Tero Kristo
2019-11-07 14:05 ` [PATCHv2 " Tero Kristo
2019-11-13 14:25 ` Rob Herring
2019-10-28 12:42 ` [PATCH 02/17] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo
2019-11-09 1:03 ` Bjorn Andersson
2019-11-12 8:16 ` Tero Kristo
2019-12-20 3:30 ` Suman Anna
2019-10-28 12:42 ` [PATCH 03/17] remoteproc/omap: Add device tree support Tero Kristo
2019-11-11 23:16 ` Bjorn Andersson
2019-11-12 8:14 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 04/17] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo
2019-11-11 23:18 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 05/17] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo
2019-11-11 23:21 ` Bjorn Andersson
2019-11-12 8:21 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 06/17] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo
2019-11-11 23:22 ` Bjorn Andersson
2019-11-12 8:22 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 07/17] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo
2019-11-11 23:23 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 08/17] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo
2019-11-11 23:37 ` Bjorn Andersson
2019-11-12 8:37 ` Tero Kristo
2019-11-12 18:13 ` Bjorn Andersson
2019-11-13 8:08 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 09/17] remoteproc/omap: Remove the unused fields from platform data Tero Kristo
2019-11-11 23:37 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 10/17] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Tero Kristo
2019-11-11 23:37 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 11/17] remoteproc/omap: Check for undefined mailbox messages Tero Kristo
2019-11-11 23:39 ` Bjorn Andersson
2019-11-12 8:38 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 12/17] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo
2019-11-12 4:13 ` Bjorn Andersson
2019-11-12 8:42 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 13/17] remoteproc/omap: add support for system suspend/resume Tero Kristo
2019-11-12 6:15 ` Bjorn Andersson [this message]
2019-11-12 8:45 ` Tero Kristo
2019-11-12 18:06 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 14/17] remoteproc/omap: add support for runtime auto-suspend/resume Tero Kristo
2019-10-28 12:42 ` [PATCH 15/17] remoteproc/omap: report device exceptions and trigger recovery Tero Kristo
2019-11-12 6:26 ` Bjorn Andersson
2019-11-12 8:46 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 16/17] remoteproc/omap: add watchdog functionality for remote processors Tero Kristo
2019-10-28 12:42 ` [PATCH 17/17] remoteproc/omap: fix auto-suspend failure warning during crashed state Tero Kristo
2019-11-12 6:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112061536.GO3108315@builder \
--to=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).