linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] net: ethernet: ti: Add dependency for TI_DAVINCI_EMAC
@ 2019-11-12  6:33 Mao Wenan
  2019-11-12 18:51 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-11-12  6:33 UTC (permalink / raw)
  To: davem, andrew, grygorii.strashko, tony, brouer, jakub.kicinski,
	ivan.khoronzhuk, tglx, maowenan
  Cc: netdev, linux-kernel, kernel-janitors

If TI_DAVINCI_EMAC=y and GENERIC_ALLOCATOR is not set,
below erros can be seen:
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.14':
davinci_cpdma.c:(.text+0x359): undefined reference to `gen_pool_size'
davinci_cpdma.c:(.text+0x365): undefined reference to `gen_pool_avail'
davinci_cpdma.c:(.text+0x373): undefined reference to `gen_pool_avail'
davinci_cpdma.c:(.text+0x37f): undefined reference to `gen_pool_size'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free':
davinci_cpdma.c:(.text+0x4a2): undefined reference to `gen_pool_free_owner'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit_si':
davinci_cpdma.c:(.text+0x66c): undefined reference to `gen_pool_alloc_algo_owner'
davinci_cpdma.c:(.text+0x805): undefined reference to `gen_pool_free_owner'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
davinci_cpdma.c:(.text+0xabd): undefined reference to `devm_gen_pool_create'
davinci_cpdma.c:(.text+0xb79): undefined reference to `gen_pool_add_owner'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
davinci_cpdma.c:(.text+0x16c6): undefined reference to `gen_pool_avail'

This patch mades TI_DAVINCI_EMAC select GENERIC_ALLOCATOR.

Fixes: 99f629718272 ("net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 834afca3..137632b 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -22,6 +22,7 @@ config TI_DAVINCI_EMAC
 	depends on ARM && ( ARCH_DAVINCI || ARCH_OMAP3 ) || COMPILE_TEST
 	select TI_DAVINCI_MDIO
 	select PHYLIB
+	select GENERIC_ALLOCATOR
 	---help---
 	  This driver supports TI's DaVinci Ethernet .
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] net: ethernet: ti: Add dependency for TI_DAVINCI_EMAC
  2019-11-12  6:33 [PATCH -next] net: ethernet: ti: Add dependency for TI_DAVINCI_EMAC Mao Wenan
@ 2019-11-12 18:51 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-12 18:51 UTC (permalink / raw)
  To: maowenan
  Cc: andrew, grygorii.strashko, tony, brouer, jakub.kicinski,
	ivan.khoronzhuk, tglx, netdev, linux-kernel, kernel-janitors

From: Mao Wenan <maowenan@huawei.com>
Date: Tue, 12 Nov 2019 14:33:58 +0800

> If TI_DAVINCI_EMAC=y and GENERIC_ALLOCATOR is not set,
> below erros can be seen:
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.14':
> davinci_cpdma.c:(.text+0x359): undefined reference to `gen_pool_size'
> davinci_cpdma.c:(.text+0x365): undefined reference to `gen_pool_avail'
> davinci_cpdma.c:(.text+0x373): undefined reference to `gen_pool_avail'
> davinci_cpdma.c:(.text+0x37f): undefined reference to `gen_pool_size'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free':
> davinci_cpdma.c:(.text+0x4a2): undefined reference to `gen_pool_free_owner'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit_si':
> davinci_cpdma.c:(.text+0x66c): undefined reference to `gen_pool_alloc_algo_owner'
> davinci_cpdma.c:(.text+0x805): undefined reference to `gen_pool_free_owner'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
> davinci_cpdma.c:(.text+0xabd): undefined reference to `devm_gen_pool_create'
> davinci_cpdma.c:(.text+0xb79): undefined reference to `gen_pool_add_owner'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
> davinci_cpdma.c:(.text+0x16c6): undefined reference to `gen_pool_avail'
> 
> This patch mades TI_DAVINCI_EMAC select GENERIC_ALLOCATOR.
> 
> Fixes: 99f629718272 ("net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-12 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12  6:33 [PATCH -next] net: ethernet: ti: Add dependency for TI_DAVINCI_EMAC Mao Wenan
2019-11-12 18:51 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).