From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86952C17440 for ; Tue, 12 Nov 2019 06:56:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 515CB206A3 for ; Tue, 12 Nov 2019 06:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OlFvdt3w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbfKLG4m (ORCPT ); Tue, 12 Nov 2019 01:56:42 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:35944 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfKLG4l (ORCPT ); Tue, 12 Nov 2019 01:56:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WzJP5ecelfPrbPkpFdZW5saIiDsiXjsKrOz9Vo/Rvb0=; b=OlFvdt3wLOwmBUAZk2yEp4RNW I3bct+sprhJ6pz1IsQYpJkg8FZDpj28AVlIHBeoHgWxYKaFSrgigAQoslr65aDVp+bGS+jUUpPnf7 +0pwKUa0rB4i+8tBxIRr2+gglGQoqUvEVP9aqoJWfBTbysXf8MBtKCC6mc2MUYiUd4rEEGlb8Vzmz zdH9ghLmseScW4y7uV88+9flHR3xHMMJVsvg7KfHo7sPjyA3sqXSYWk6cnu2qcGLjFry7PGzwYTVg a7zaeMrFGOsbUGeBh1bEH9eftnbXBBcs+swwnOa83egkEtbN0At9pMmDOANTZdwPKwNZyONoemVXo iR7q83i7A==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUQ4x-0005RM-4z; Tue, 12 Nov 2019 06:55:07 +0000 Date: Mon, 11 Nov 2019 22:55:07 -0800 From: Christoph Hellwig To: ira.weiny@intel.com Cc: Alexander Viro , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Jaegeuk Kim , Chao Yu , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Trond Myklebust , Anna Schumaker , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Jan Kara Subject: Re: [PATCH 2/2] fs: Move swap_[de]activate to file_operations Message-ID: <20191112065507.GA15915@infradead.org> References: <20191112003452.4756-1-ira.weiny@intel.com> <20191112003452.4756-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112003452.4756-3-ira.weiny@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 04:34:52PM -0800, ira.weiny@intel.com wrote: > From: Ira Weiny > > swap_activate() and swap_deactivate() have nothing to do with > address spaces. We want to eventually make the address space operations > dynamic to switch inode flags on the fly. So to simplify this code as > well as properly track these operations we move these functions to the > file_operations vector. What is the point? If we switch aops for DAX vs not we might as well switch file operations as well, as they pretty much are entirely different.