From: Christoph Hellwig <hch@infradead.org>
To: Evan Green <evgreen@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Martin K Petersen <martin.petersen@oracle.com>,
Gwendal Grignou <gwendal@chromium.org>,
Ming Lei <ming.lei@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Alexis Savery <asavery@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Bart Van Assche <bvanassche@acm.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] loop: Report EOPNOTSUPP properly
Date: Tue, 12 Nov 2019 00:32:08 -0800 [thread overview]
Message-ID: <20191112083208.GA1848@infradead.org> (raw)
In-Reply-To: <20191111185030.215451-2-evgreen@chromium.org>
On Mon, Nov 11, 2019 at 10:50:29AM -0800, Evan Green wrote:
> - if (cmd->ret < 0)
> + if (cmd->ret == -EOPNOTSUPP)
> + ret = BLK_STS_NOTSUPP;
> + else if (cmd->ret < 0)
> ret = BLK_STS_IOERR;
This really should use errno_to_blk_status. Same for the other hunk.
next prev parent reply other threads:[~2019-11-12 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 18:50 [PATCH v6 0/2] loop: Better discard for block devices Evan Green
2019-11-11 18:50 ` [PATCH v6 1/2] loop: Report EOPNOTSUPP properly Evan Green
2019-11-12 8:32 ` Christoph Hellwig [this message]
2019-11-12 19:09 ` Evan Green
2019-11-14 23:19 ` Evan Green
2019-11-11 18:50 ` [PATCH v6 2/2] loop: Better discard support for block devices Evan Green
2019-11-12 1:36 ` Darrick J. Wong
2019-11-12 17:22 ` Evan Green
2019-11-13 0:39 ` Darrick J. Wong
2019-11-13 16:30 ` Evan Green
2019-11-12 1:32 ` [PATCH v6 0/2] loop: Better discard " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112083208.GA1848@infradead.org \
--to=hch@infradead.org \
--cc=asavery@chromium.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).