From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: dt-bindings: spi-controller: add wakeup-source and interrupts
Date: Tue, 12 Nov 2019 19:15:47 +0000 [thread overview]
Message-ID: <20191112191547.GK5195@sirena.co.uk> (raw)
In-Reply-To: <20191112190328.GA199853@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
On Tue, Nov 12, 2019 at 11:03:28AM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 12, 2019 at 12:03:07PM +0000, Mark Brown wrote:
> > On Mon, Nov 11, 2019 at 09:54:10PM -0800, Dmitry Torokhov wrote:
> > > + interrupts:
> > > + items:
> > > + - description: main interrupt (attention) line.
> > > + - description: dedicated wakeup interrupt.
> > > + minItems: 1 # The wakeup interrupt is optional.
> > > + interrupt-names:
> > > + items:
> > > + - const: irq
> > > + - const: wakeup
> > > + minItems: 1
> > How will this interact with a SPI device that defines interrupts at the
> > device level, possibly more than one of them? Especially if the device
> > has its own idea what the interrupts should be called.
> My understanding that individual drivers should be able to override
> whatever the default behavior core has configured, and the device can
> establish their own mapping. We have this in I2C and I believe this
> works well.
> Is the concern about the device tree scheme or SPI core handling?
Both really.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-12 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 5:54 [PATCH 0/2] spi: add wakeup handling to SPI core Dmitry Torokhov
2019-11-12 5:54 ` [PATCH 1/2] spi: dt-bindings: spi-controller: add wakeup-source and interrupts Dmitry Torokhov
2019-11-12 12:03 ` Mark Brown
2019-11-12 19:03 ` Dmitry Torokhov
2019-11-12 19:15 ` Mark Brown [this message]
2019-11-12 19:36 ` Dmitry Torokhov
2019-11-12 19:42 ` Mark Brown
2019-11-14 22:26 ` Rob Herring
2019-11-14 23:08 ` Dmitry Torokhov
2019-11-15 13:52 ` Rob Herring
2019-11-15 15:22 ` Mark Brown
2019-11-15 19:43 ` Rob Herring
2019-11-12 5:54 ` [PATCH 2/2] spi: wire up wakeup-source/wakeirq handling Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112191547.GK5195@sirena.co.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).