From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: question about setting TPM_CHIP_FLAG_IRQ in tpm_tis_core_init
Date: Tue, 12 Nov 2019 22:17:16 +0200 [thread overview]
Message-ID: <20191112201716.GA12340@linux.intel.com> (raw)
In-Reply-To: <6d6f0899-8ba0-d6cf-ef3b-317ca698b687@linux.ibm.com>
On Tue, Nov 12, 2019 at 08:28:57AM -0500, Stefan Berger wrote:
> I set this flag for the TIS because it wasn't set anywhere else.
> tpm_tis_send() wouldn't set the flag but go via the path:
>
> if (!(chip->flags & TPM_CHIP_FLAG_IRQ) || priv->irq_tested)
>
> return tpm_tis_send_main(chip, buf, len);
Wondering why this isn't just "if (priv->irq_tested)"? Isn't that the
whole point. The tail is the test part e.g. should be executed when
IRQ testing is done.
/Jarkko
next prev parent reply other threads:[~2019-11-12 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 3:36 question about setting TPM_CHIP_FLAG_IRQ in tpm_tis_core_init Jerry Snitselaar
2019-11-12 13:28 ` Stefan Berger
2019-11-12 14:24 ` Jerry Snitselaar
2019-11-12 15:35 ` Stefan Berger
2019-11-12 20:17 ` Jarkko Sakkinen [this message]
2019-11-15 19:14 ` Jerry Snitselaar
2019-11-12 20:07 ` Jarkko Sakkinen
2019-11-12 20:17 ` Jerry Snitselaar
2019-11-12 20:30 ` Stefan Berger
2019-11-14 16:48 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112201716.GA12340@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).