From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2641C17448 for ; Wed, 13 Nov 2019 00:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC2C6206BA for ; Wed, 13 Nov 2019 00:30:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I8mJBV2H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727063AbfKMAam (ORCPT ); Tue, 12 Nov 2019 19:30:42 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35985 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbfKMAal (ORCPT ); Tue, 12 Nov 2019 19:30:41 -0500 Received: by mail-pg1-f195.google.com with SMTP id k13so140807pgh.3 for ; Tue, 12 Nov 2019 16:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q255pVhVuoq1jRHKaF0XnAkw/D7Ep/OqDcaVole5ol8=; b=I8mJBV2Hym2i6OFGHQfoLXYcyshvXngBApr/e3oxxtonq/+EDelm1NjltFabtX9Aky oV7MTkYtLb04x8iEqjZaUZrVQSd8nCCTZnw3bWuJW0TSrQKwL4au9ogsHi8n9QyY9z/x HKxlwXmQQU1/GdaVPGBjL28b/pP4/p7vSTgUeOgMlUITVQNH76UAI0UO9aLX6Rdc7v/e kpGknF+K6dsPg4S+uqTrpdklNYyDJ+IlI/8FjMYfPUpf+h+/Aq/VeMpTO5Zn5A7andnO SamWbadzDdMTQoxNexpVDplXa1nQtlwSZ1zKQs4PlS147I+3yGVro89/5jJ09KvJyX/V vMPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q255pVhVuoq1jRHKaF0XnAkw/D7Ep/OqDcaVole5ol8=; b=q+WW/sFozCMZeKvsNAhXFGgVYbFN63Zo5HONAb4qURm5HiqGGiM9Plc/G4tmQTWX2H poQf7tLKjHDMH/uyAxUWMyZ6o98GHVVkidA2MNQ9vgYaCDVHHSsZJEY58NSzpr7tzcWt t8R+owUg/ZBNipr8q+ySrI40V/1l8J/05iz292y4UweSZWgJmOBdEjBvkQRwE6cQZGFQ 4u9827c7q+x1f2Y8YXDgoc8VncUpLdvBHoRbfT9Ge78dSq7r5n8aG8FZA6T6JRwcwYWS knwLk1aQA/VhF0tYVs+5r0aNhn88jrz8j/CPeztHUJUizmyXponlNwU5zYZy9QO3hzRK umTg== X-Gm-Message-State: APjAAAXvMBJ5FkFmTyIQN3hgcdyIq+zfvPny7qjh5KY5m9fsxnuiyHgl zVWTeAU3F/WhQDixeuSA2rjDVQ== X-Google-Smtp-Source: APXvYqyKYoTasYQVQBJZt/sE02pUXLLkEGeQ9E8IHDrU7vF4AyOKWvmcjwXNRcuyn5fZrXEUF+vPAg== X-Received: by 2002:a63:c54e:: with SMTP id g14mr317356pgd.435.1573605040663; Tue, 12 Nov 2019 16:30:40 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id k190sm175851pga.12.2019.11.12.16.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 16:30:39 -0800 (PST) Date: Tue, 12 Nov 2019 16:30:36 -0800 From: Bjorn Andersson To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, sudeep.holla@arm.com, edubezval@gmail.com, agross@kernel.org, tdas@codeaurora.org, swboyd@chromium.org, ilina@codeaurora.org, "Rafael J. Wysocki" , Amit Kucheria , Ben Segall , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Peter Zijlstra , Steven Rostedt , Vincent Guittot , Zhang Rui , linux-pm@vger.kernel.org Subject: Re: [PATCH v4 6/6] cpufreq: qcom-hw: Move driver initialisation earlier Message-ID: <20191113003036.GA3143381@builder> References: <3d367762ba72fa1cbd6391dc55d94b3284f6c00c.1571387352.git.amit.kucheria@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d367762ba72fa1cbd6391dc55d94b3284f6c00c.1571387352.git.amit.kucheria@linaro.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 18 Oct 01:52 PDT 2019, Amit Kucheria wrote: > Allow qcom-hw driver to initialise right after the cpufreq and thermal > subsystems are initialised in core_initcall so we get earlier access to > thermal mitigation. > > Signed-off-by: Amit Kucheria > Acked-by: Daniel Lezcano > Acked-by: Taniya Das Hi Amit, Booting linux-next on my db845c (and SDM850 laptop) I can see that the device probes in /sys/bus/platform/drivers/qcom-cpufreq-hw, but /sys/devices/system/cpu/cpufreq is empty. Reverting this change gives me cpufreq back. Can you please have a look at this? Regards, Bjorn > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > index a9ae2f84a4efc..fc92a8842e252 100644 > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > @@ -334,7 +334,7 @@ static int __init qcom_cpufreq_hw_init(void) > { > return platform_driver_register(&qcom_cpufreq_hw_driver); > } > -device_initcall(qcom_cpufreq_hw_init); > +postcore_initcall(qcom_cpufreq_hw_init); > > static void __exit qcom_cpufreq_hw_exit(void) > { > -- > 2.17.1 >