* [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request
@ 2019-11-13 9:22 Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 1/4] i2c: at91: " Peter Ujfalusi
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Peter Ujfalusi @ 2019-11-13 9:22 UTC (permalink / raw)
To: ludovic.desroches, agross, wsa+renesas, ldewangan
Cc: vkoul, linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm,
digetx, linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
Hi,
I'm going through the tree to remove dma_request_slave_channel_reason() as it
is just:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)
Regards,
Peter
---
Peter Ujfalusi (4):
i2c: at91: Use dma_request_chan() directly for channel request
i2c: qup: Use dma_request_chan() directly for channel request
i2c: sh_mobile: Use dma_request_chan() directly for channel request
i2c: tegra: Use dma_request_chan() directly for channel request
drivers/i2c/busses/i2c-at91-master.c | 4 ++--
drivers/i2c/busses/i2c-qup.c | 4 ++--
drivers/i2c/busses/i2c-sh_mobile.c | 2 +-
drivers/i2c/busses/i2c-tegra.c | 4 ++--
4 files changed, 7 insertions(+), 7 deletions(-)
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/4] i2c: at91: Use dma_request_chan() directly for channel request
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13 9:22 ` Peter Ujfalusi
2019-11-13 13:35 ` Ludovic.Desroches
2019-11-13 9:22 ` [PATCH 2/4] i2c: qup: " Peter Ujfalusi
` (4 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Peter Ujfalusi @ 2019-11-13 9:22 UTC (permalink / raw)
To: ludovic.desroches, agross, wsa+renesas, ldewangan
Cc: vkoul, linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm,
digetx, linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/i2c/busses/i2c-at91-master.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
index 6e0b554dcd4e..7a862e00b475 100644
--- a/drivers/i2c/busses/i2c-at91-master.c
+++ b/drivers/i2c/busses/i2c-at91-master.c
@@ -758,14 +758,14 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
slave_config.dst_maxburst = 1;
slave_config.device_fc = false;
- dma->chan_tx = dma_request_slave_channel_reason(dev->dev, "tx");
+ dma->chan_tx = dma_request_chan(dev->dev, "tx");
if (IS_ERR(dma->chan_tx)) {
ret = PTR_ERR(dma->chan_tx);
dma->chan_tx = NULL;
goto error;
}
- dma->chan_rx = dma_request_slave_channel_reason(dev->dev, "rx");
+ dma->chan_rx = dma_request_chan(dev->dev, "rx");
if (IS_ERR(dma->chan_rx)) {
ret = PTR_ERR(dma->chan_rx);
dma->chan_rx = NULL;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] i2c: qup: Use dma_request_chan() directly for channel request
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 1/4] i2c: at91: " Peter Ujfalusi
@ 2019-11-13 9:22 ` Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 3/4] i2c: sh_mobile: " Peter Ujfalusi
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Peter Ujfalusi @ 2019-11-13 9:22 UTC (permalink / raw)
To: ludovic.desroches, agross, wsa+renesas, ldewangan
Cc: vkoul, linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm,
digetx, linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/i2c/busses/i2c-qup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index e09cd0775ae9..2d7dabe12723 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -628,7 +628,7 @@ static int qup_i2c_req_dma(struct qup_i2c_dev *qup)
int err;
if (!qup->btx.dma) {
- qup->btx.dma = dma_request_slave_channel_reason(qup->dev, "tx");
+ qup->btx.dma = dma_request_chan(qup->dev, "tx");
if (IS_ERR(qup->btx.dma)) {
err = PTR_ERR(qup->btx.dma);
qup->btx.dma = NULL;
@@ -638,7 +638,7 @@ static int qup_i2c_req_dma(struct qup_i2c_dev *qup)
}
if (!qup->brx.dma) {
- qup->brx.dma = dma_request_slave_channel_reason(qup->dev, "rx");
+ qup->brx.dma = dma_request_chan(qup->dev, "rx");
if (IS_ERR(qup->brx.dma)) {
dev_err(qup->dev, "\n rx channel not available");
err = PTR_ERR(qup->brx.dma);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] i2c: sh_mobile: Use dma_request_chan() directly for channel request
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 1/4] i2c: at91: " Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 2/4] i2c: qup: " Peter Ujfalusi
@ 2019-11-13 9:22 ` Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 4/4] i2c: tegra: " Peter Ujfalusi
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Peter Ujfalusi @ 2019-11-13 9:22 UTC (permalink / raw)
To: ludovic.desroches, agross, wsa+renesas, ldewangan
Cc: vkoul, linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm,
digetx, linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/i2c/busses/i2c-sh_mobile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 8777af4c695e..82b3b795e0bd 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -486,7 +486,7 @@ static struct dma_chan *sh_mobile_i2c_request_dma_chan(struct device *dev,
char *chan_name = dir == DMA_MEM_TO_DEV ? "tx" : "rx";
int ret;
- chan = dma_request_slave_channel_reason(dev, chan_name);
+ chan = dma_request_chan(dev, chan_name);
if (IS_ERR(chan)) {
dev_dbg(dev, "request_channel failed for %s (%ld)\n", chan_name,
PTR_ERR(chan));
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/4] i2c: tegra: Use dma_request_chan() directly for channel request
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
` (2 preceding siblings ...)
2019-11-13 9:22 ` [PATCH 3/4] i2c: sh_mobile: " Peter Ujfalusi
@ 2019-11-13 9:22 ` Peter Ujfalusi
2019-11-14 7:05 ` Jon Hunter
2019-11-14 4:34 ` [PATCH 0/4] i2c: " Vinod Koul
2019-11-14 20:43 ` Wolfram Sang
5 siblings, 1 reply; 9+ messages in thread
From: Peter Ujfalusi @ 2019-11-13 9:22 UTC (permalink / raw)
To: ludovic.desroches, agross, wsa+renesas, ldewangan
Cc: vkoul, linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm,
digetx, linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/i2c/busses/i2c-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index c1683f9338b4..a98bf31d0e5c 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -413,7 +413,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
return 0;
}
- chan = dma_request_slave_channel_reason(i2c_dev->dev, "rx");
+ chan = dma_request_chan(i2c_dev->dev, "rx");
if (IS_ERR(chan)) {
err = PTR_ERR(chan);
goto err_out;
@@ -421,7 +421,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
i2c_dev->rx_dma_chan = chan;
- chan = dma_request_slave_channel_reason(i2c_dev->dev, "tx");
+ chan = dma_request_chan(i2c_dev->dev, "tx");
if (IS_ERR(chan)) {
err = PTR_ERR(chan);
goto err_out;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] i2c: at91: Use dma_request_chan() directly for channel request
2019-11-13 9:22 ` [PATCH 1/4] i2c: at91: " Peter Ujfalusi
@ 2019-11-13 13:35 ` Ludovic.Desroches
0 siblings, 0 replies; 9+ messages in thread
From: Ludovic.Desroches @ 2019-11-13 13:35 UTC (permalink / raw)
To: peter.ujfalusi
Cc: agross, wsa+renesas, ldewangan, vkoul, linux-i2c, linux-kernel,
linux-arm-kernel, linux-arm-msm, digetx, linux-tegra,
thierry.reding, jonathanh, Nicolas.Ferre, alexandre.belloni,
bjorn.andersson
On Wed, Nov 13, 2019 at 11:22:32AM +0200, Peter Ujfalusi wrote:
>
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
> ---
> drivers/i2c/busses/i2c-at91-master.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
> index 6e0b554dcd4e..7a862e00b475 100644
> --- a/drivers/i2c/busses/i2c-at91-master.c
> +++ b/drivers/i2c/busses/i2c-at91-master.c
> @@ -758,14 +758,14 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
> slave_config.dst_maxburst = 1;
> slave_config.device_fc = false;
>
> - dma->chan_tx = dma_request_slave_channel_reason(dev->dev, "tx");
> + dma->chan_tx = dma_request_chan(dev->dev, "tx");
> if (IS_ERR(dma->chan_tx)) {
> ret = PTR_ERR(dma->chan_tx);
> dma->chan_tx = NULL;
> goto error;
> }
>
> - dma->chan_rx = dma_request_slave_channel_reason(dev->dev, "rx");
> + dma->chan_rx = dma_request_chan(dev->dev, "rx");
> if (IS_ERR(dma->chan_rx)) {
> ret = PTR_ERR(dma->chan_rx);
> dma->chan_rx = NULL;
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
` (3 preceding siblings ...)
2019-11-13 9:22 ` [PATCH 4/4] i2c: tegra: " Peter Ujfalusi
@ 2019-11-14 4:34 ` Vinod Koul
2019-11-14 20:43 ` Wolfram Sang
5 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2019-11-14 4:34 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: ludovic.desroches, agross, wsa+renesas, ldewangan, linux-i2c,
linux-kernel, linux-arm-kernel, linux-arm-msm, digetx,
linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
On 13-11-19, 11:22, Peter Ujfalusi wrote:
> Hi,
>
> I'm going through the tree to remove dma_request_slave_channel_reason() as it
> is just:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] i2c: tegra: Use dma_request_chan() directly for channel request
2019-11-13 9:22 ` [PATCH 4/4] i2c: tegra: " Peter Ujfalusi
@ 2019-11-14 7:05 ` Jon Hunter
0 siblings, 0 replies; 9+ messages in thread
From: Jon Hunter @ 2019-11-14 7:05 UTC (permalink / raw)
To: Peter Ujfalusi, ludovic.desroches, agross, wsa+renesas, ldewangan
Cc: vkoul, linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm,
digetx, linux-tegra, thierry.reding, nicolas.ferre,
alexandre.belloni, bjorn.andersson
On 13/11/2019 09:22, Peter Ujfalusi wrote:
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index c1683f9338b4..a98bf31d0e5c 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -413,7 +413,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
> return 0;
> }
>
> - chan = dma_request_slave_channel_reason(i2c_dev->dev, "rx");
> + chan = dma_request_chan(i2c_dev->dev, "rx");
> if (IS_ERR(chan)) {
> err = PTR_ERR(chan);
> goto err_out;
> @@ -421,7 +421,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
>
> i2c_dev->rx_dma_chan = chan;
>
> - chan = dma_request_slave_channel_reason(i2c_dev->dev, "tx");
> + chan = dma_request_chan(i2c_dev->dev, "tx");
> if (IS_ERR(chan)) {
> err = PTR_ERR(chan);
> goto err_out;
>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
` (4 preceding siblings ...)
2019-11-14 4:34 ` [PATCH 0/4] i2c: " Vinod Koul
@ 2019-11-14 20:43 ` Wolfram Sang
5 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2019-11-14 20:43 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: ludovic.desroches, agross, wsa+renesas, ldewangan, vkoul,
linux-i2c, linux-kernel, linux-arm-kernel, linux-arm-msm, digetx,
linux-tegra, thierry.reding, jonathanh, nicolas.ferre,
alexandre.belloni, bjorn.andersson
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Wed, Nov 13, 2019 at 11:22:31AM +0200, Peter Ujfalusi wrote:
> Hi,
>
> I'm going through the tree to remove dma_request_slave_channel_reason() as it
> is just:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)
>
> Regards,
> Peter
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-11-14 20:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 9:22 [PATCH 0/4] i2c: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 1/4] i2c: at91: " Peter Ujfalusi
2019-11-13 13:35 ` Ludovic.Desroches
2019-11-13 9:22 ` [PATCH 2/4] i2c: qup: " Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 3/4] i2c: sh_mobile: " Peter Ujfalusi
2019-11-13 9:22 ` [PATCH 4/4] i2c: tegra: " Peter Ujfalusi
2019-11-14 7:05 ` Jon Hunter
2019-11-14 4:34 ` [PATCH 0/4] i2c: " Vinod Koul
2019-11-14 20:43 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).