From: Rob Herring <robh@kernel.org>
To: Al Cooper <alcooperx@gmail.com>
Cc: linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Srinath Mannam <srinath.mannam@broadcom.com>
Subject: Re: [PATCH 06/13] dt-bindings: Add Broadcom STB USB PHY binding document
Date: Wed, 13 Nov 2019 19:20:13 -0600 [thread overview]
Message-ID: <20191114012013.GA25050@bogus> (raw)
In-Reply-To: <20191107141339.6079-7-alcooperx@gmail.com>
On Thu, Nov 07, 2019 at 09:13:32AM -0500, Al Cooper wrote:
> Add support for bcm7216 and bcm7211
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
> .../bindings/phy/brcm,brcmstb-usb-phy.txt | 69 +++++++++++++++----
> 1 file changed, 56 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> index 24a0d06acd1d..14184cec15dc 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> @@ -1,30 +1,49 @@
> Broadcom STB USB PHY
>
> Required properties:
> - - compatible: brcm,brcmstb-usb-phy
> - - reg: two offset and length pairs.
> - The first pair specifies a manditory set of memory mapped
> - registers used for general control of the PHY.
> - The second pair specifies optional registers used by some of
> - the SoCs that support USB 3.x
> - - #phy-cells: Shall be 1 as it expects one argument for setting
> - the type of the PHY. Possible values are:
> - - PHY_TYPE_USB2 for USB1.1/2.0 PHY
> - - PHY_TYPE_USB3 for USB3.x PHY
> +- compatible: should be one of
> + "brcm,brcmstb-usb-phy"
> + "brcm,bcm7216-usb-phy"
> + "brcm,bcm7211-usb-phy"
> +
> +- reg and reg-names properties requirements are specific to the
> + compatible string.
> + "brcm,brcmstb-usb-phy":
> + - reg: 1 or 2 offset and length pairs. One for the base CTRL registers
> + and an optional pair for systems with USB 3.x support
> + - reg-names: not specified
> + "brcm,bcm7216-usb-phy":
> + - reg: 3 offset and length pairs for CTRL, XHCI_EC and XHCI_GBL
> + registers
> + - reg-names: "ctrl", "xhci_ec", "xhci_gbl"
> + "brcm,bcm7211-usb-phy":
> + - reg: 5 offset and length pairs for CTRL, XHCI_EC, XHCI_GBL,
> + USB_PHY and USB_MDIO registers and an optional pair
> + for the BDC registers
> + - reg-names: "ctrl", "xhci_ec", "xhci_gbl", "usb_phy", "usb_mdio", "bdc_ec"
> +
> +- #phy-cells: Shall be 1 as it expects one argument for setting
> + the type of the PHY. Possible values are:
> + - PHY_TYPE_USB2 for USB1.1/2.0 PHY
> + - PHY_TYPE_USB3 for USB3.x PHY
>
> Optional Properties:
> - clocks : clock phandles.
> - clock-names: String, clock name.
> +- interrupts: wake interrupt
> +- interrupt-names: "wake"
If a wakeup source, the standard name is 'wakeup'.
> - brcm,ipp: Boolean, Invert Port Power.
> Possible values are: 0 (Don't invert), 1 (Invert)
> - brcm,ioc: Boolean, Invert Over Current detection.
> Possible values are: 0 (Don't invert), 1 (Invert)
> -NOTE: one or both of the following two properties must be set
> -- brcm,has-xhci: Boolean indicating the phy has an XHCI phy.
> -- brcm,has-eohci: Boolean indicating the phy has an EHCI/OHCI phy.
> - dr_mode: String, PHY Device mode.
> Possible values are: "host", "peripheral ", "drd" or "typec-pd"
> If this property is not defined, the phy will default to "host" mode.
> +- syscon-piarbctl: phandle to syscon for handling config registers
Needs vendor prefix.
> +NOTE: one or both of the following two properties must be set
> +- brcm,has-xhci: Boolean indicating the phy has an XHCI phy.
> +- brcm,has-eohci: Boolean indicating the phy has an EHCI/OHCI phy.
> +
>
> Example:
>
> @@ -41,3 +60,27 @@ usbphy_0: usb-phy@f0470200 {
> clocks = <&usb20>, <&usb30>;
> clock-names = "sw_usb", "sw_usb3";
> };
> +
> +usb-phy@29f0200 {
> + reg = <0x29f0200 0x200>,
> + <0x29c0880 0x30>,
> + <0x29cc100 0x534>,
> + <0x2808000 0x24>,
> + <0x2980080 0x8>;
> + reg-names = "ctrl",
> + "xhci_ec",
> + "xhci_gbl",
> + "usb_phy",
> + "usb_mdio";
> + brcm,ioc = <0x0>;
> + brcm,ipp = <0x0>;
> + compatible = "brcm,bcm7211-usb-phy";
> + interrupts = <0x30>;
> + interrupt-parent = <&vpu_intr1_nosec_intc>;
> + interrupt-names = "wake";
> + #phy-cells = <0x1>;
> + brcm,has-xhci;
> + syscon-piarbctl = <&syscon_piarbctl>;
> + clocks = <&scmi_clk 256>;
> + clock-names = "sw_usb";
> +};
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-11-14 1:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 14:13 [PATCH 00/13] phy: usb: Updates to Broadcom STB USB PHY driver Al Cooper
2019-11-07 14:13 ` [PATCH 01/13] phy: usb: EHCI DMA may lose a burst of DMA data for 7255xA0 family Al Cooper
2019-11-07 14:13 ` [PATCH 02/13] phy: usb: Get all drivers that use USB clks using correct enable/disable Al Cooper
2019-11-07 14:13 ` [PATCH 03/13] phy: usb: Put USB phys into IDDQ on suspend to save power in S2 mode Al Cooper
2019-11-07 14:13 ` [PATCH 04/13] phy: usb: Add "wake on" functionality Al Cooper
2019-11-07 14:13 ` [PATCH 05/13] phy: usb: Restructure in preparation for adding 7216 USB support Al Cooper
2019-11-07 14:13 ` [PATCH 06/13] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper
2019-11-14 1:20 ` Rob Herring [this message]
2019-11-07 14:13 ` [PATCH 07/13] phy: usb: Add support for new Synopsis USB controller on the 7216 Al Cooper
2019-11-07 14:13 ` [PATCH 08/13] phy: usb: Add support for new Synopsis USB controller on the 7211b0 Al Cooper
2019-11-07 14:13 ` [PATCH 09/13] phy: usb: fix driver to defer on clk_get defer Al Cooper
2019-11-07 14:13 ` [PATCH 10/13] phy: usb: PHY's MDIO registers not accessible without device installed Al Cooper
2019-11-07 14:13 ` [PATCH 11/13] phy: usb: bdc: Fix occasional failure with BDC on 7211 Al Cooper
2019-11-07 14:13 ` [PATCH 12/13] phy: usb: USB driver is crashing during S3 resume on 7216 Al Cooper
2019-11-07 14:13 ` [PATCH 13/13] phy: usb: Add support for wake and USB low power mode for 7211 S2/S5 Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114012013.GA25050@bogus \
--to=robh@kernel.org \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).