From: Tejun Heo <tj@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: jack@suse.cz, gregkh@linuxfoundation.org,
cgroups@vger.kernel.org, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, axboe@kernel.dk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] writeback: fix -Wformat compilation warnings
Date: Thu, 14 Nov 2019 11:21:18 -0800 [thread overview]
Message-ID: <20191114192118.GK4163745@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <1573751861-10303-1-git-send-email-cai@lca.pw>
On Thu, Nov 14, 2019 at 12:17:41PM -0500, Qian Cai wrote:
> The commit f05499a06fb4 ("writeback: use ino_t for inodes in
> tracepoints") introduced a lot of GCC compilation warnings on s390,
>
> In file included from ./include/trace/define_trace.h:102,
> from ./include/trace/events/writeback.h:904,
> from fs/fs-writeback.c:82:
> ./include/trace/events/writeback.h: In function
> 'trace_raw_output_writeback_page_template':
> ./include/trace/events/writeback.h:76:12: warning: format '%lu' expects
> argument of type 'long unsigned int', but argument 4 has type 'ino_t'
> {aka 'unsigned int'} [-Wformat=]
> TP_printk("bdi %s: ino=%lu index=%lu",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/trace/trace_events.h:360:22: note: in definition of macro
> 'DECLARE_EVENT_CLASS'
> trace_seq_printf(s, print); \
> ^~~~~
> ./include/trace/events/writeback.h:76:2: note: in expansion of macro
> 'TP_printk'
> TP_printk("bdi %s: ino=%lu index=%lu",
> ^~~~~~~~~
>
> Fix them by adding necessary casts where ino_t could be either "unsigned
> int" or "unsigned long".
>
> Fixes: f05499a06fb4 ("writeback: use ino_t for inodes in tracepoints")
> Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2019-11-14 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 17:17 [PATCH -next] writeback: fix -Wformat compilation warnings Qian Cai
2019-11-14 19:21 ` Tejun Heo [this message]
2019-11-15 0:26 ` Qian Cai
2019-11-15 14:55 ` Tejun Heo
2019-11-20 19:56 ` Qian Cai
2019-11-20 23:17 ` Jens Axboe
2019-11-25 15:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114192118.GK4163745@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=borntraeger@de.ibm.com \
--cc=cai@lca.pw \
--cc=cgroups@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).