From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF9AC43141 for ; Thu, 14 Nov 2019 19:59:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55E7C206F0 for ; Thu, 14 Nov 2019 19:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfKNT7o (ORCPT ); Thu, 14 Nov 2019 14:59:44 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:60949 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfKNT7n (ORCPT ); Thu, 14 Nov 2019 14:59:43 -0500 X-Originating-IP: 90.65.92.102 Received: from localhost (lfbn-1-1723-102.w90-65.abo.wanadoo.fr [90.65.92.102]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 910841C0007; Thu, 14 Nov 2019 19:59:41 +0000 (UTC) Date: Thu, 14 Nov 2019 20:59:41 +0100 From: Alexandre Belloni To: Andrey Skvortsov , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: tps65910: allow using RTC without alarm interrupt Message-ID: <20191114195941.GL3572@piout.net> References: <20191109154652.7419-1-andrej.skvortzov@gmail.com> <20191111171915.GA3572@piout.net> <20191113230805.GH13629@skv.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113230805.GH13629@skv.local> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2019 02:08:05+0300, Andrey Skvortsov wrote: > > > static int tps65910_rtc_probe(struct platform_device *pdev) > > > { > > > struct tps65910 *tps65910 = NULL; > > > @@ -415,13 +422,17 @@ static int tps65910_rtc_probe(struct platform_device *pdev) > > > tps65910_rtc_interrupt, IRQF_TRIGGER_LOW, > > > dev_name(&pdev->dev), &pdev->dev); > > > if (ret < 0) { > > > - dev_err(&pdev->dev, "IRQ is not free.\n"); > > > - return ret; > > > + dev_err(&pdev->dev, "request IRQ:%d failed, err = %d\n", > > > + irq, ret); > > > > Do we actually need an error message here? > > You are right. This is definitely not an error anymore. > What about > dev_warn(&pdev->dev, "unable to request IRQ, alarms disabled\n"); > like some other drivers do? > Yes, or that can be left out completely as userspace will be able to know whether alarms are supported without this message. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com