* [RFC PATCH linux-next] ASoC: rt5677: rt5677_check_hotword() can be static
2019-11-14 15:33 [linux-next:master 10267/11220] sound/soc/codecs/rt5677.c:5246:6: sparse: sparse: symbol 'rt5677_check_hotword' was not declared. Should it be static? kbuild test robot
@ 2019-11-14 15:33 ` kbuild test robot
2019-11-14 17:02 ` Curtis Malainey
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-14 15:33 UTC (permalink / raw)
To: Ben Zhang
Cc: kbuild-all, Mark Brown, Curtis Malainey, Bard Liao, Oder Chiou,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
linux-kernel
Fixes: 21c00e5df439 ("ASoC: rt5677: Enable jack detect while DSP is running")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
rt5677.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 48955b22262fa..cd01a3a8daa82 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5243,7 +5243,7 @@ static const struct rt5677_irq_desc rt5677_irq_descs[] = {
},
};
-bool rt5677_check_hotword(struct rt5677_priv *rt5677)
+static bool rt5677_check_hotword(struct rt5677_priv *rt5677)
{
int reg_gpio;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [linux-next:master 10267/11220] sound/soc/codecs/rt5677.c:5246:6: sparse: sparse: symbol 'rt5677_check_hotword' was not declared. Should it be static?
@ 2019-11-14 15:33 kbuild test robot
2019-11-14 15:33 ` [RFC PATCH linux-next] ASoC: rt5677: rt5677_check_hotword() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-14 15:33 UTC (permalink / raw)
To: Ben Zhang
Cc: kbuild-all, Mark Brown, Curtis Malainey, Bard Liao, Oder Chiou,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4e8f108c3af2d6922a64df9f3d3d488c74f6009d
commit: 21c00e5df4397870ee835c974bf50570f9d24253 [10267/11220] ASoC: rt5677: Enable jack detect while DSP is running
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-31-gfd3528a-dirty
git checkout 21c00e5df4397870ee835c974bf50570f9d24253
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/rt5677.c:4700:17: sparse: sparse: dubious: x | !y
>> sound/soc/codecs/rt5677.c:5246:6: sparse: sparse: symbol 'rt5677_check_hotword' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH linux-next] ASoC: rt5677: rt5677_check_hotword() can be static
2019-11-14 15:33 ` [RFC PATCH linux-next] ASoC: rt5677: rt5677_check_hotword() can be static kbuild test robot
@ 2019-11-14 17:02 ` Curtis Malainey
0 siblings, 0 replies; 3+ messages in thread
From: Curtis Malainey @ 2019-11-14 17:02 UTC (permalink / raw)
To: kbuild test robot
Cc: Ben Zhang, kbuild-all, Mark Brown, Curtis Malainey, Bard Liao,
Oder Chiou, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
ALSA development, Linux Kernel Mailing List
On Thu, Nov 14, 2019 at 7:33 AM kbuild test robot <lkp@intel.com> wrote:
>
>
> Fixes: 21c00e5df439 ("ASoC: rt5677: Enable jack detect while DSP is running")
> Signed-off-by: kbuild test robot <lkp@intel.com>
Acked-by: Curtis Malainey <cujomalainey@chromium.org>
> ---
> rt5677.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 48955b22262fa..cd01a3a8daa82 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5243,7 +5243,7 @@ static const struct rt5677_irq_desc rt5677_irq_descs[] = {
> },
> };
>
> -bool rt5677_check_hotword(struct rt5677_priv *rt5677)
> +static bool rt5677_check_hotword(struct rt5677_priv *rt5677)
> {
> int reg_gpio;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-14 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 15:33 [linux-next:master 10267/11220] sound/soc/codecs/rt5677.c:5246:6: sparse: sparse: symbol 'rt5677_check_hotword' was not declared. Should it be static? kbuild test robot
2019-11-14 15:33 ` [RFC PATCH linux-next] ASoC: rt5677: rt5677_check_hotword() can be static kbuild test robot
2019-11-14 17:02 ` Curtis Malainey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).