From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F4FC432C3 for ; Fri, 15 Nov 2019 20:42:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5ED0D20733 for ; Fri, 15 Nov 2019 20:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbfKOUm5 (ORCPT ); Fri, 15 Nov 2019 15:42:57 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726549AbfKOUm5 (ORCPT ); Fri, 15 Nov 2019 15:42:57 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 48CE514E1447C; Fri, 15 Nov 2019 12:42:56 -0800 (PST) Date: Fri, 15 Nov 2019 12:42:55 -0800 (PST) Message-Id: <20191115.124255.1583855143943561160.davem@davemloft.net> To: hslester96@gmail.com Cc: hsweeten@visionengravers.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove From: David Miller In-Reply-To: <20191114154324.31990-1-hslester96@gmail.com> References: <20191114154324.31990-1-hslester96@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Nov 2019 12:42:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan Date: Thu, 14 Nov 2019 23:43:24 +0800 > The driver calls release_resource in remove to match request_mem_region > in probe, which is incorrect. > Fix it by using the right one, release_mem_region. > > Signed-off-by: Chuhong Yuan Applied, thanks. It's a shame that you can't just pass in the thing you got back from request_mem_region() to free it. And honestly the only thing that makes calling release_region() wrong is that release_region() doesn't free up the region object after unlinking it from the tree.