From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D3EAC432C3 for ; Fri, 15 Nov 2019 07:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8F7D2073B for ; Fri, 15 Nov 2019 07:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573803336; bh=mLLWq4Q9t6JYXaA+/g91tarumyqaredMuFnxy71bjq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ylE9IM2RCL8fUQuXGnQT23z8UA78RQI12kwBzhTgxw2nh3YlrwPHZpI8bqf81sBuU EeLmCcw+FlWfcEbh3BvqspeC2B0BSBKom/z/AMN7teGvtU7Y4TT5OzJ8lEMXvxH273 t6W8miy2vx+8rbWrIKxuWZi5dPf3tzPlJebMqVic= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbfKOHfg (ORCPT ); Fri, 15 Nov 2019 02:35:36 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46844 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfKOHff (ORCPT ); Fri, 15 Nov 2019 02:35:35 -0500 Received: by mail-wr1-f67.google.com with SMTP id b3so9784091wrs.13; Thu, 14 Nov 2019 23:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XNVJd5dcCTBvmn7nz6XkF50cNru+9ij6quw5fX29eLs=; b=fIIYYkZFNvCLpTdcC3uK9BUXkoDL8Kj2P4ew7vITPQF5NsmgLHqdNf/l+yq6kKtk5T khk0WxPcSFEEyungCP+Ii/BzlsSgz/Hlelxk15gZDwpagEUO65j8cprZbawi06Vyp+48 S9CnueNVUuikj9L6xdHYXUWAVJN81BRpFD/3/SQIFf8asg4/gKrl4zywe1ch1SBs7HLp h5g7QsTxdJrZYw+GpKj9GYWIjH5nsKSS5FKvlvRAlM4poJqQoVCzZAmiMRx8Bp+5yKEg uoBV8Nxv2OKxLiqd8EzuvyshgA4xROGvWdprTLZosAepXFwXBaZ15rCUXHgV5vfmZrBQ 6x2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=XNVJd5dcCTBvmn7nz6XkF50cNru+9ij6quw5fX29eLs=; b=ZP2Rs01IrndkQ4D2RiYOZYqccCGjzVapnR0YKvsnmO96bJq+Py0Kqrkxq5JeISRxzT 33U4JKLZlBY9U8E3xuwcvgx+r+2AfNSHijkVT1TYyZ2ARQSlGu1fDY5mARR69dxbazv5 YNy59MGxnbkF+glqfGLGpedwX3LIgdgEfSwORKmkUWmn0gAR1xg6VwxH23f66ofIrJUB AYdC/crkg1ipxCmGjcrefFTIx/WiSMVuChKc904P1Xmy4cXtMhOzwUDHllsgL8rkJN2K V3aHd2ASWLJ9KXostqEGepieVmdrPgyjRyOeiVuCTfV0tq5cjjsrTAM+RIDpLLT+Q4fY wZ6w== X-Gm-Message-State: APjAAAXnggsdYnz8Svz3C6mDWk/Ty4Q5LC8HJTDrPaQH+N64QJL5tayW DhgwbotJ9+hyFyBwtYBVAH+3/Vyn X-Google-Smtp-Source: APXvYqx6gerzVgEgOOtYhr3z+pwPamEp/9nCmarZUxvWYGdKbG7yEaHR8oIUC28uBNe+6jrgE91pDA== X-Received: by 2002:adf:a51c:: with SMTP id i28mr13824388wrb.147.1573803331555; Thu, 14 Nov 2019 23:35:31 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id v184sm9405061wme.31.2019.11.14.23.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 23:35:30 -0800 (PST) Date: Fri, 15 Nov 2019 08:35:28 +0100 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: Thomas Gleixner , Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Ian Rogers , Ravi Bangoria , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL] perf/core improvements and fixes Message-ID: <20191115073528.GA124116@gmail.com> References: <20191112183757.28660-1-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112183757.28660-1-acme@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Hi Ingo/Thomas, > > Please consider pulling, > > Best regards, > > - Arnaldo > > Test results at the end of this message, as usual. > > The following changes since commit 56b2147f34d057b0898c53a3eb2e9e70756ab89f: > > Merge tag 'perf-core-for-mingo-5.5-20191107' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2019-11-12 12:06:08 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf-core-for-mingo-5.5-20191112 > > for you to fetch changes up to e1e9b78d3957a267346a86c8f2c433f6a332af65: > > perf parse: Use YYABORT to clear stack after failure, plugging leaks (2019-11-12 08:34:16 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > perf record: > > Ravi Bangoria: > > - Provide an option to print perf_event_open args and syscall return value. > This was already possible using -v, but then lots of other debug info > would be output as well, provide a way to show just the syscall args > and return value, e.g.: > > # perf --debug perf-event-open=1 record > perf_event_attr: > size 112 > { sample_period, sample_freq } 4000 > sample_type IP|TID|TIME|PERIOD > read_format ID > disabled 1 > inherit 1 > > ksymbol 1 > bpf_event 1 > ------------------------------------------------------------ > sys_perf_event_open: pid 4308 cpu 0 group_fd -1 flags 0x8 = 4 > > core: > > - Remove map->groups, we can get that information in other ways, reduces > the size of a key data structure and paves the way to have it shared > by multiple threads. > > - Use 'struct map_symbol' in more places, where we already were using a > 'struct map' + 'struct symbol', this helps passing that usual pair of > information across callchain, browser code, etc. > > - Add 'struct map_groups' (where the map_symbol->map is) to 'struct map_symbol', > to ease annotation code, for instance, where we call from functions in one map > we're browsing to functions in another DSO, mapped in another 'struct map'. > > event parsing: > > Ian Rogers: > > - Use YYABORT to clear stack after failure, plugging leaks > > Signed-off-by: Arnaldo Carvalho de Melo > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (13): > perf map: Use map->dso->kernel + map__kmaps() in map__kmaps() > perf symbols: Stop using map->groups, we can use kmaps instead > perf map_groups: Pass the object to map_groups__find_ams() > perf tools: Add map_groups to 'struct addr_location' > perf annotate: Pass a 'map_symbol' in places receiving a pair of 'map' and 'symbol' pointers > perf unwind: Use 'struct map_symbol' in 'struct unwind_entry' > perf callchain: Use 'struct map_symbol' in 'struct callchain_cursor_node' > pref tools: Make 'struct addr_map_symbol' contain 'struct map_symbol' > perf symbols: Use kmaps(map)->machine when we know its a kernel map > perf tools: Add a 'struct map_groups' pointer to 'struct map_symbol' > perf annotate: Stop using map->groups, use map_symbol->mg instead > perf map: Combine maps__fixup_overlappings with its only use > perf map: Remove ->groups from 'struct map' > > Ian Rogers (1): > perf parse: Use YYABORT to clear stack after failure, plugging leaks > > Ravi Bangoria (1): > perf tool: Provide an option to print perf_event_open args and return value > > tools/perf/Documentation/perf.txt | 2 + > tools/perf/arch/s390/annotate/instructions.c | 8 +- > tools/perf/builtin-annotate.c | 6 +- > tools/perf/builtin-kmem.c | 4 +- > tools/perf/builtin-report.c | 2 +- > tools/perf/builtin-sched.c | 2 +- > tools/perf/builtin-top.c | 6 +- > tools/perf/tests/dwarf-unwind.c | 2 +- > tools/perf/ui/browsers/annotate.c | 25 +++-- > tools/perf/ui/browsers/hists.c | 20 ++-- > tools/perf/ui/gtk/annotate.c | 27 +++--- > tools/perf/util/annotate.c | 105 ++++++++++----------- > tools/perf/util/annotate.h | 22 ++--- > tools/perf/util/callchain.c | 40 ++++---- > tools/perf/util/callchain.h | 5 +- > tools/perf/util/db-export.c | 16 ++-- > tools/perf/util/debug.c | 2 + > tools/perf/util/debug.h | 9 ++ > tools/perf/util/event.c | 6 +- > tools/perf/util/evsel.c | 36 +++---- > tools/perf/util/evsel_fprintf.c | 29 +++--- > tools/perf/util/hist.c | 58 ++++++------ > tools/perf/util/machine.c | 48 ++++++---- > tools/perf/util/map.c | 46 +++------ > tools/perf/util/map.h | 1 - > tools/perf/util/map_groups.h | 2 +- > tools/perf/util/map_symbol.h | 5 +- > tools/perf/util/mem-events.c | 2 +- > tools/perf/util/parse-events.y | 3 +- > tools/perf/util/python.c | 1 + > .../perf/util/scripting-engines/trace-event-perl.c | 16 ++-- > .../util/scripting-engines/trace-event-python.c | 18 ++-- > tools/perf/util/sort.c | 89 ++++++++--------- > tools/perf/util/symbol-elf.c | 2 +- > tools/perf/util/symbol.c | 16 +--- > tools/perf/util/symbol.h | 2 +- > tools/perf/util/unwind-libdw.c | 7 +- > tools/perf/util/unwind-libunwind-local.c | 7 +- > tools/perf/util/unwind.h | 8 +- > 39 files changed, 347 insertions(+), 358 deletions(-) Pulled, thanks a lot Arnaldo! Ingo