From: Michael Grzeschik <mgr@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
shawnguo@kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx25: fix usbhost1 node
Date: Fri, 15 Nov 2019 09:28:28 +0100 [thread overview]
Message-ID: <20191115082828.tc3dbjnv7bojgrg4@pengutronix.de> (raw)
In-Reply-To: <20191114211708.77d6bttkyj426yqy@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
On Thu, Nov 14, 2019 at 10:17:08PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 11, 2019 at 12:46:56PM +0100, Michael Grzeschik wrote:
> > The usb port represented by &usbhost1 uses an USB phy internal to the
> > SoC. We add the phy_type to the base dtsi so the board dts only have to
> > overwrite it if they use a different configuration. While at it we also
> > pin the usbhost port to host mode.
> >
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks for the ACK.
I just figured out that we also can add the limitation
to maximum-speed = "full-speed" into to dts. Since the
internal phy maximum speed is limited to that.
I will send an v2.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-15 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 11:46 [PATCH] ARM: dts: imx25: fix usbhost1 node Michael Grzeschik
2019-11-14 21:17 ` Uwe Kleine-König
2019-11-15 8:28 ` Michael Grzeschik [this message]
2019-11-15 8:34 ` [PATCH v2] " Michael Grzeschik
2019-11-15 20:14 ` Uwe Kleine-König
2019-11-20 8:29 ` Michael Grzeschik
2019-11-20 21:13 ` [PATCH v3 0/2] ARM: dts: imx25: usbhost port1 improvemts Michael Grzeschik
2019-11-20 21:13 ` [PATCH v3 1/2] ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file Michael Grzeschik
2019-11-20 21:27 ` Fabio Estevam
2019-11-20 21:13 ` [PATCH v3 2/2] ARM: dts: imx25: describe maximum speed of internal usbhost port1 phy Michael Grzeschik
2019-11-20 21:28 ` Fabio Estevam
2019-12-04 12:22 ` [PATCH v3 0/2] ARM: dts: imx25: usbhost port1 improvemts Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115082828.tc3dbjnv7bojgrg4@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).