From: Peter Zijlstra <peterz@infradead.org>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [RFC PATCH v3 6/7] scripts/sorttable: Add ORC unwind tables sort concurrently
Date: Fri, 15 Nov 2019 10:07:23 +0100 [thread overview]
Message-ID: <20191115090723.GS4114@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191115064750.47888-7-shile.zhang@linux.alibaba.com>
On Fri, Nov 15, 2019 at 02:47:49PM +0800, Shile Zhang wrote:
> +#if defined(SORTTABLE_64) && defined(UNWINDER_ORC_ENABLED)
> +/* ORC unwinder only support X86_64 */
> +#include <errno.h>
> +#include <pthread.h>
> +#include <linux/types.h>
> +
> +#define ORC_REG_UNDEFINED 0
> +#define ERRSTRING_MAXSZ 256
> +
> +struct orc_entry {
> + s16 sp_offset;
> + s16 bp_offset;
> + unsigned sp_reg:4;
> + unsigned bp_reg:4;
> + unsigned type:2;
> + unsigned end:1;
> +} __attribute__((packed));
> +
> +struct orctable_info {
> + size_t orc_size;
> + size_t orc_ip_size;
> +} orctable;
There's ./arch/x86/include/asm/orc_types.h for this. Please don't
duplicate. objtool uses that same header.
> +/**
> + * sort - sort an array of elements
> + * @base: pointer to data to sort
> + * @num: number of elements
> + * @size: size of each element
> + * @cmp_func: pointer to comparison function
> + * @swap_func: pointer to swap function
> + *
> + * This function does a heapsort on the given array. You may provide a
> + * swap_func function optimized to your element type.
> + *
> + * Sorting time is O(n log n) both on average and worst-case. While
> + * qsort is about 20% faster on average, it suffers from exploitable
> + * O(n*n) worst-case behavior and extra memory requirements that make
> + * it less suitable for kernel use.
> + *
> + * This code token out of /lib/sort.c.
> + */
> +static void sort(void *base, size_t num, size_t size,
> + int (*cmp_func)(const void *, const void *),
> + void (*swap_func)(void *, void *, int size))
> +{
> + /* pre-scale counters for performance */
> + int i = (num/2 - 1) * size, n = num * size, c, r;
> +
> + /* heapify */
> + for ( ; i >= 0; i -= size) {
> + for (r = i; r * 2 + size < n; r = c) {
> + c = r * 2 + size;
> + if (c < n - size &&
> + cmp_func(base + c, base + c + size) < 0)
> + c += size;
> + if (cmp_func(base + r, base + c) >= 0)
> + break;
> + swap_func(base + r, base + c, size);
> + }
> + }
> +
> + /* sort */
> + for (i = n - size; i > 0; i -= size) {
> + swap_func(base, base + i, size);
> + for (r = 0; r * 2 + size < i; r = c) {
> + c = r * 2 + size;
> + if (c < i - size &&
> + cmp_func(base + c, base + c + size) < 0)
> + c += size;
> + if (cmp_func(base + r, base + c) >= 0)
> + break;
> + swap_func(base + r, base + c, size);
> + }
> + }
> +}
Do we really need to copy the heapsort implementation? That is, why not
use libc's qsort() ? This is userspace after all.
next prev parent reply other threads:[~2019-11-15 9:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 6:47 [RFC PATCH v3 0/7] Speed booting by sorting ORC unwind tables at build time Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 1/7] scripts/sortextable: Rewrite error/success handling Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 2/7] scripts/sortextable: kernel coding style formating Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 3/7] scripts/sortextable: Remove dead code Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 4/7] scripts/sortextable: refactor do_func() function Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 5/7] scripts/sorttable: rename sortextable to sorttable Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 6/7] scripts/sorttable: Add ORC unwind tables sort concurrently Shile Zhang
2019-11-15 9:07 ` Peter Zijlstra [this message]
2019-11-15 9:43 ` Shile Zhang
2019-11-15 10:33 ` Peter Zijlstra
2019-11-15 17:24 ` Andy Lutomirski
2019-11-18 11:43 ` Shile Zhang
2019-11-15 9:19 ` Peter Zijlstra
2019-11-15 9:45 ` Shile Zhang
2019-11-15 6:47 ` [RFC PATCH v3 7/7] x86/unwind/orc: remove run-time ORC unwind tables sort Shile Zhang
2019-11-15 16:51 ` David Laight
2019-11-15 17:46 ` Josh Poimboeuf
2019-11-18 10:05 ` David Laight
2019-11-18 10:50 ` Shile Zhang
2019-11-18 14:41 ` Josh Poimboeuf
2019-11-15 7:25 ` [RFC PATCH v3 0/7] Speed booting by sorting ORC unwind tables at build time Ingo Molnar
2019-11-15 8:24 ` Shile Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115090723.GS4114@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=shile.zhang@linux.alibaba.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).