From: Juri Lelli <juri.lelli@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, will@kernel.org, oleg@redhat.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
bigeasy@linutronix.de, williams@redhat.com, bristot@redhat.com,
longman@redhat.com, dave@stgolabs.net, jack@suse.com
Subject: Re: [PATCH 0/5] locking: Percpu-rwsem rewrite
Date: Fri, 15 Nov 2019 18:14:50 +0100 [thread overview]
Message-ID: <20191115171450.GJ19129@localhost.localdomain> (raw)
In-Reply-To: <20191113102115.116470462@infradead.org>
Hi,
On 13/11/19 11:21, Peter Zijlstra wrote:
> Yet another version of the percpu-rwsem rewrite..
>
> This one (ab)uses the waitqueue in an entirely different and unique way, but no
> longer shares it like it did. It retains the use of rcuwait for the
> writer-waiting-for-readers-to-complete condition.
>
> This one should be FIFO fair with writer-stealing.
>
> It seems to pass locktorture torture_type=percpu_rwsem_lock. But as always,
> this stuff is tricky, please look carefully.
Backported this series to v5.2.21-rt13.
locktorture looks good (running for several hours) and DEBUG_LOCKS splat
[1] not reproducible anymore.
Tested-by: Juri Lelli <juri.lelli@redhat.com>
Thanks!
Juri
1 - https://lore.kernel.org/lkml/20190326093421.GA29508@localhost.localdomain/
prev parent reply other threads:[~2019-11-15 17:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:21 [PATCH 0/5] locking: Percpu-rwsem rewrite Peter Zijlstra
2019-11-13 10:21 ` [PATCH 1/5] locking/percpu-rwsem, lockdep: Make percpu-rwsem use its own lockdep_map Peter Zijlstra
2019-11-15 20:39 ` Davidlohr Bueso
2020-01-08 1:33 ` [PATCH] locking/percpu-rwsem: Add might_sleep() for writer locking Davidlohr Bueso
2020-01-08 1:33 ` Davidlohr Bueso
2020-02-11 12:48 ` [tip: locking/core] " tip-bot2 for Davidlohr Bueso
2019-11-13 10:21 ` [PATCH 2/5] locking/percpu-rwsem: Convert to bool Peter Zijlstra
2019-11-13 10:21 ` [PATCH 3/5] locking/percpu-rwsem: Move __this_cpu_inc() into the slowpath Peter Zijlstra
2019-11-13 10:21 ` [PATCH 4/5] locking/percpu-rwsem: Extract __percpu_down_read_trylock() Peter Zijlstra
2019-11-18 16:28 ` Oleg Nesterov
2019-11-13 10:21 ` [PATCH 5/5] locking/percpu-rwsem: Remove the embedded rwsem Peter Zijlstra
2019-11-18 19:53 ` Davidlohr Bueso
2019-11-18 23:19 ` Davidlohr Bueso
2019-12-17 10:45 ` Peter Zijlstra
2019-12-17 10:35 ` Peter Zijlstra
2019-11-18 21:52 ` Waiman Long
2019-12-17 10:28 ` Peter Zijlstra
2019-11-19 13:50 ` Waiman Long
2019-11-19 15:58 ` Oleg Nesterov
2019-11-19 16:28 ` Waiman Long
2019-12-17 10:26 ` Peter Zijlstra
2019-12-17 10:28 ` Peter Zijlstra
2019-11-15 17:14 ` Juri Lelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115171450.GJ19129@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=dave@stgolabs.net \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).