From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 10/12] perf stat: Use affinity for reading
Date: Fri, 15 Nov 2019 10:37:39 -0800 [thread overview]
Message-ID: <20191115183739.GC22747@tassilo.jf.intel.com> (raw)
In-Reply-To: <20191115145535.GC4255@krava>
> > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> > index ca82a93960cd..c8af4bc23f8f 100644
> > --- a/tools/perf/util/evsel.h
> > +++ b/tools/perf/util/evsel.h
> > @@ -86,6 +86,7 @@ struct evsel {
> > struct list_head config_terms;
> > struct bpf_object *bpf_obj;
> > int bpf_fd;
> > + int err;
>
> I was wondering what would be the best place for this,
> and all the previous variables u added and this one
> are stat specific, so I think this all belongs to
>
> (struct perf_stat_evsel*) evsel->stat
I hope to eventually make perf record use affinity too.
Just not in this patchkit. So I'll keep them in the generic
evsel for now.
-Andi
next prev parent reply other threads:[~2019-11-15 18:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:59 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-12 0:59 ` [PATCH v6 01/12] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-12 0:59 ` [PATCH v6 02/12] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-12 0:59 ` [PATCH v6 03/12] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-12 0:59 ` [PATCH v6 04/12] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-12 0:59 ` [PATCH v6 05/12] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-12 0:59 ` [PATCH v6 06/12] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-12 0:59 ` [PATCH v6 07/12] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-12 0:59 ` [PATCH v6 08/12] perf stat: Factor out open error handling Andi Kleen
2019-11-12 0:59 ` [PATCH v6 09/12] perf stat: Use affinity for opening events Andi Kleen
2019-11-12 0:59 ` [PATCH v6 10/12] perf stat: Use affinity for reading Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-15 14:55 ` Jiri Olsa
2019-11-15 18:37 ` Andi Kleen [this message]
2019-11-15 14:55 ` Jiri Olsa
2019-11-12 0:59 ` [PATCH v6 11/12] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-12 0:59 ` [PATCH v6 12/12] perf stat: Use affinity for enabling/disabling events Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115183739.GC22747@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).