From: kbuild test robot <lkp@intel.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: kbuild-all@lists.01.org, broonie@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, marek.vasut@gmail.com,
dwmw2@infradead.org, computersforpeace@gmail.com,
vigneshr@ti.com, bbrezillon@kernel.org,
tudor.ambarus@microchip.com, juliensu@mxic.com.tw,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, Mason Yang <masonccyang@mxic.com.tw>,
Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH 2/4] mtd: spi-nor: Add support for Octal 8D-8D-8D mode
Date: Fri, 15 Nov 2019 20:30:51 +0800 [thread overview]
Message-ID: <201911152022.zJV1d7Tk%lkp@intel.com> (raw)
In-Reply-To: <1573808288-19365-3-git-send-email-masonccyang@mxic.com.tw>
[-- Attachment #1: Type: text/plain, Size: 2855 bytes --]
Hi Mason,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.4-rc7]
[cannot apply to next-20191114]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mason-Yang/mtd-spi-nor-Add-support-for-Octal-8D-8D-8D-mode/20191115-170233
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers//mtd/spi-nor/spi-nor.c: In function 'erase_chip':
>> drivers//mtd/spi-nor/spi-nor.c:1001:25: warning: large integer implicitly truncated to unsigned type [-Woverflow]
op.cmd.ext_opcode = ~SPINOR_OP_CHIP_ERASE;
^
At top level:
drivers//mtd/spi-nor/spi-nor.c:621:12: warning: 'write_cr2' defined but not used [-Wunused-function]
static int write_cr2(struct spi_nor *nor, u32 addr, u8 val)
^~~~~~~~~
vim +1001 drivers//mtd/spi-nor/spi-nor.c
976
977 /*
978 * Erase the whole flash memory
979 *
980 * Returns 0 if successful, non-zero otherwise.
981 */
982 static int erase_chip(struct spi_nor *nor)
983 {
984 dev_dbg(nor->dev, " %lldKiB\n", (long long)(nor->mtd.size >> 10));
985
986 if (nor->spimem) {
987 struct spi_mem_op op =
988 SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_CHIP_ERASE, 1),
989 SPI_MEM_OP_NO_ADDR,
990 SPI_MEM_OP_NO_DUMMY,
991 SPI_MEM_OP_NO_DATA);
992
993 if (spi_nor_protocol_is_8_8_8(nor->write_proto)) {
994 op.cmd.buswidth = 8;
995 op.cmd.nbytes = 2;
996
997 if (spi_nor_protocol_is_8D_8D_8D(nor->write_proto))
998 op.cmd.dtr = true;
999
1000 if (nor->ext_cmd_mode == EXT_CMD_IS_INVERSE)
> 1001 op.cmd.ext_opcode = ~SPINOR_OP_CHIP_ERASE;
1002 else
1003 op.cmd.ext_opcode = SPINOR_OP_CHIP_ERASE;
1004 }
1005
1006 return spi_mem_exec_op(nor->spimem, &op);
1007 }
1008
1009 return nor->write_reg(nor, SPINOR_OP_CHIP_ERASE, NULL, 0);
1010 }
1011
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50138 bytes --]
next prev parent reply other threads:[~2019-11-15 12:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 8:58 [PATCH 0/4] mtd: spi-nor: Add support for Octal 8D-8D-8D mode Mason Yang
2019-11-15 8:58 ` [PATCH 1/4] spi: spi-mem: " Mason Yang
2019-11-15 8:58 ` [PATCH 2/4] mtd: spi-nor: " Mason Yang
2019-11-15 12:30 ` kbuild test robot [this message]
2019-11-15 13:42 ` kbuild test robot
2019-12-04 12:46 ` Vignesh Raghavendra
2019-12-09 7:56 ` masonccyang
2019-12-09 9:53 ` Vignesh Raghavendra
2019-12-10 7:21 ` masonccyang
2019-11-15 8:58 ` [PATCH 3/4] mtd: spi-nor: Add Octal 8D-8D-8D mode support for Macronix mx25uw51245g Mason Yang
2019-12-04 13:03 ` Vignesh Raghavendra
2019-12-09 6:38 ` masonccyang
2019-11-15 8:58 ` [PATCH 4/4] spi: mxic: Add support for Octal 8D-8D-8D mode Mason Yang
2019-11-15 14:39 ` kbuild test robot
2019-11-16 7:20 ` kbuild test robot
2019-12-10 17:00 ` [PATCH 0/4] mtd: spi-nor: " Tudor.Ambarus
2019-12-11 2:14 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911152022.zJV1d7Tk%lkp@intel.com \
--to=lkp@intel.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=juliensu@mxic.com.tw \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).