From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A65C432C3 for ; Fri, 15 Nov 2019 22:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 285742072D for ; Fri, 15 Nov 2019 22:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbfKOWwB (ORCPT ); Fri, 15 Nov 2019 17:52:01 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:56154 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbfKOWwA (ORCPT ); Fri, 15 Nov 2019 17:52:00 -0500 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iVkRP-0005U8-CP; Fri, 15 Nov 2019 22:51:47 +0000 Date: Fri, 15 Nov 2019 23:51:46 +0100 From: Christian Brauner To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: Adrian Reber , Eric Biederman , Pavel Emelyanov , Jann Horn , Oleg Nesterov , Andrei Vagin , Rasmus Villemoes , linux-kernel@vger.kernel.org, Mike Rapoport , Radostin Stoyanov Subject: Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID Message-ID: <20191115225145.c6r5avibiluzxj3c@wittgenstein> References: <20191115123621.142252-1-areber@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 15, 2019 at 04:54:06PM +0000, Dmitry Safonov wrote: > On 11/15/19 12:36 PM, Adrian Reber wrote: > [..] > > Signed-off-by: Adrian Reber > > Reviewed-by: Christian Brauner > > Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com> > > [though, I have 2 minor nits below] > > [..] > > + * @set_tid: Pointer to an array of type *pid_t. The size > > + * of the array is defined using @set_tid_size. > > + * This array is used select PIDs/TIDs for newly > > /is used select/is used to select/s I fixed this up while applying. Thanks! Christian