From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA03C432C3 for ; Sat, 16 Nov 2019 16:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8367C2089D for ; Sat, 16 Nov 2019 16:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573921014; bh=TsHlTSdvhxWTQ1hfq+x90Y74xridxkUGzUUUPZWjXMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UH93XaGAIKkF+WDyyGvEZQ1kFyNKmWBFxjRdK2jJuoV7nCf+DA2Sv08bfWK+KgkLO nhOwLn+x13MvAr7PITRolHRD9mLREHWgsCsKASBzZbSlivqoyt4WuS4T1GfMpF5YIX vnFhtsJUSJJ+K/JyoAny3qRIORNfWBtY1F3LcLiY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731975AbfKPQQx (ORCPT ); Sat, 16 Nov 2019 11:16:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:53556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728885AbfKPPqz (ORCPT ); Sat, 16 Nov 2019 10:46:55 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC9C2208CE; Sat, 16 Nov 2019 15:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573919215; bh=TsHlTSdvhxWTQ1hfq+x90Y74xridxkUGzUUUPZWjXMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fi5baKaCLLb4vjT81al/eJXH88eHJ0QqOfCC2IrGl1bvoUimanJiXNX1+TXM00/In d0BfoUFCzSU59hAvq6XnGfB8KDRsFH3Q5SC0rK2ZuXM80m65ktU2Apcqg9p/VYo0Qg mM4lwKvjN2txsGLpcjtV8WPafYs55x3HE6XkaX/0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: YueHaibing , "David S . Miller" , Sasha Levin , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 221/237] net: bcmgenet: return correct value 'ret' from bcmgenet_power_down Date: Sat, 16 Nov 2019 10:40:56 -0500 Message-Id: <20191116154113.7417-221-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116154113.7417-1-sashal@kernel.org> References: <20191116154113.7417-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 0db55093b56618088b9a1d445eb6e43b311bea33 ] Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function 'bcmgenet_power_down': drivers/net/ethernet/broadcom/genet/bcmgenet.c:1136:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] bcmgenet_power_down should return 'ret' instead of 0. Fixes: ca8cf341903f ("net: bcmgenet: propagate errors from bcmgenet_power_down") Signed-off-by: YueHaibing Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index bb60104b4f805..338d223804343 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -1169,7 +1169,7 @@ static int bcmgenet_power_down(struct bcmgenet_priv *priv, break; } - return 0; + return ret; } static void bcmgenet_power_up(struct bcmgenet_priv *priv, -- 2.20.1